Fix caching issue for ClientLibsCompress and updates for Issue 1143: Remove GWT-related code #245
Fix caching issue for ClientLibsCompress and updates for Issue 1143: Remove GWT-related code #245labkey-susanh wants to merge 5 commits into
ClientLibsCompress and updates for Issue 1143: Remove GWT-related code #245Conversation
There was a problem hiding this comment.
I spent a while on Friday trying to repro and fix the caching problem with Claude.
In addition to this change to ClientLibsCompress, it suggested excluding XmlImporters from the list of output files when they have doCompile==false. This seems correct since compressSingleFile also skips such importers.
It also suggested declaring isDevMode as an input for that task so that dev and production builds don't share cache keys.
…we aren't doing any minification
Done. Our conversations with Claude were clearly a bit different. I've also removed the "combined" file as an output since I can't find reference to it anywhere or remember where it was needed. If you or anyone you know recognizes it as necessary we can happily restore it. |
Rationale
Issue 1143: We have removed all usages of GWT in the code so no longer need the plugin or extension.
ClientLibsCompresshad improper logic related to its declaration of output files, leading to some intermittent failures on TeamCity when the task got annotated as aCacheableTaskGradle 9.5.1 is the latest
Related Pull Requests
Changes
ClientLibsCompresstask