Skip to content

Fix caching issue for ClientLibsCompress and updates for Issue 1143: Remove GWT-related code #245

Open
labkey-susanh wants to merge 5 commits into
developfrom
fb_removeGwt
Open

Fix caching issue for ClientLibsCompress and updates for Issue 1143: Remove GWT-related code #245
labkey-susanh wants to merge 5 commits into
developfrom
fb_removeGwt

Conversation

@labkey-susanh
Copy link
Copy Markdown
Contributor

@labkey-susanh labkey-susanh commented May 18, 2026

Rationale

Issue 1143: We have removed all usages of GWT in the code so no longer need the plugin or extension.

ClientLibsCompress had improper logic related to its declaration of output files, leading to some intermittent failures on TeamCity when the task got annotated as a CacheableTask

Gradle 9.5.1 is the latest

Related Pull Requests

Changes

  • Update to Gradle 9.5.1
  • Remove GWT plugin and extension
  • Fix caching bug related to output file declaration for ClientLibsCompress task

Copy link
Copy Markdown
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent a while on Friday trying to repro and fix the caching problem with Claude.
In addition to this change to ClientLibsCompress, it suggested excluding XmlImporters from the list of output files when they have doCompile==false. This seems correct since compressSingleFile also skips such importers.
It also suggested declaring isDevMode as an input for that task so that dev and production builds don't share cache keys.

@labkey-susanh
Copy link
Copy Markdown
Contributor Author

I spent a while on Friday trying to repro and fix the caching problem with Claude. In addition to this change to ClientLibsCompress, it suggested excluding XmlImporters from the list of output files when they have doCompile==false. This seems correct since compressSingleFile also skips such importers. It also suggested declaring isDevMode as an input for that task so that dev and production builds don't share cache keys.

Done. Our conversations with Claude were clearly a bit different.

I've also removed the "combined" file as an output since I can't find reference to it anywhere or remember where it was needed. If you or anyone you know recognizes it as necessary we can happily restore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants