fix: keep servroot off Docker Desktop bind mounts#751
Open
raoxiaoyan wants to merge 1 commit intomasterfrom
Open
fix: keep servroot off Docker Desktop bind mounts#751raoxiaoyan wants to merge 1 commit intomasterfrom
raoxiaoyan wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Pongo to keep Kong’s runtime prefix (servroot) off Docker Desktop bind mounts by moving it to a named Docker volume, improving reliability for Unix sockets on macOS/Windows and standardizing log access via in-container commands.
Changes:
- Mount
/kong-plugin/servrootas a named Docker volume and ensure it’s initialized/writable in the container entrypoint. - Update
pongo tailto tail logs from inside a container (works on Docker Desktop and CI) and add runtime-prefix clearing beforepongo run. - Refresh documentation/help text to reflect the in-container runtime prefix and log access patterns.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates debugging/log access docs and examples for the in-container runtime prefix. |
| pongo.sh | Adds container bash path helper, runtime-prefix volume clearing, and reworks tail to run in-container. |
| assets/pongo_entrypoint.sh | Sets KONG_PREFIX and ensures runtime directories exist and are writable. |
| assets/help/tail.txt | Clarifies that tail runs inside the Kong container and how paths are resolved. |
| assets/help/run.txt | Documents runtime-prefix clearing behavior and interaction with KONG_TEST_DONT_CLEAN. |
| assets/help/pongo.txt | Updates top-level help text for tail behavior. |
| assets/docker-compose.yml | Introduces pongo-kong-runtime-prefix named volume and mounts it at /kong-plugin/servroot. |
| assets/ci/pongo_run.helper.sh | Adjusts CI cleanup to target the runtime prefix inside the container/volume. |
| assets/ci/pongo_docker.test.sh | Adjusts Docker-based CI cleanup to target the runtime prefix inside the container/volume. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e30d86c to
74eaa3f
Compare
74eaa3f to
845d53b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FTI-7288