Skip to content

fix: keep servroot off Docker Desktop bind mounts#751

Open
raoxiaoyan wants to merge 1 commit intomasterfrom
fix/FTI-7288-new
Open

fix: keep servroot off Docker Desktop bind mounts#751
raoxiaoyan wants to merge 1 commit intomasterfrom
fix/FTI-7288-new

Conversation

@raoxiaoyan
Copy link
Copy Markdown

@raoxiaoyan raoxiaoyan commented May 7, 2026

FTI-7288

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Pongo to keep Kong’s runtime prefix (servroot) off Docker Desktop bind mounts by moving it to a named Docker volume, improving reliability for Unix sockets on macOS/Windows and standardizing log access via in-container commands.

Changes:

  • Mount /kong-plugin/servroot as a named Docker volume and ensure it’s initialized/writable in the container entrypoint.
  • Update pongo tail to tail logs from inside a container (works on Docker Desktop and CI) and add runtime-prefix clearing before pongo run.
  • Refresh documentation/help text to reflect the in-container runtime prefix and log access patterns.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
README.md Updates debugging/log access docs and examples for the in-container runtime prefix.
pongo.sh Adds container bash path helper, runtime-prefix volume clearing, and reworks tail to run in-container.
assets/pongo_entrypoint.sh Sets KONG_PREFIX and ensures runtime directories exist and are writable.
assets/help/tail.txt Clarifies that tail runs inside the Kong container and how paths are resolved.
assets/help/run.txt Documents runtime-prefix clearing behavior and interaction with KONG_TEST_DONT_CLEAN.
assets/help/pongo.txt Updates top-level help text for tail behavior.
assets/docker-compose.yml Introduces pongo-kong-runtime-prefix named volume and mounts it at /kong-plugin/servroot.
assets/ci/pongo_run.helper.sh Adjusts CI cleanup to target the runtime prefix inside the container/volume.
assets/ci/pongo_docker.test.sh Adjusts Docker-based CI cleanup to target the runtime prefix inside the container/volume.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pongo.sh Outdated
Comment thread pongo.sh Outdated
Comment thread assets/pongo_entrypoint.sh
Comment thread README.md Outdated
Comment thread assets/ci/pongo_run.helper.sh Outdated
Comment thread assets/ci/pongo_docker.test.sh Outdated
@raoxiaoyan raoxiaoyan force-pushed the fix/FTI-7288-new branch 2 times, most recently from e30d86c to 74eaa3f Compare May 8, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants