Skip to content

fix(*) only mount logs directory and use a different prefix (#474)#482

Draft
Tieske wants to merge 2 commits intomasterfrom
support/3.4
Draft

fix(*) only mount logs directory and use a different prefix (#474)#482
Tieske wants to merge 2 commits intomasterfrom
support/3.4

Conversation

@Tieske
Copy link
Copy Markdown
Contributor

@Tieske Tieske commented Dec 15, 2023

Since Kong 3.0 unix sockets have been introduced and spurious failures have been observed on MacOS and Windows systems when using Pongo.

The issue is the unix-sockets being created by Kong (inside the container) on the filesystem that is mounted from the host. This is not supported on Windows and MacOS, though seems to work most of the time, just not always (exact cause unclear).

The fix is 2 fold;

  • a change to the test-helpers (Kong side)
  • a change to Pongo (this branch)

The Pongo change in this PR will make it work if the Kong patch is available, but if it isn't then it will always fail, instead of only occasionally. Confirmed versions to fail: 3.2+ both CE and EE.

Hence this PR will only work with Kong versions that have been patched. At the time of writing that is:

  • Kong 3.6+, both CE and EE (not released yet, but the fix is in master)
  • Kong 3.4 EE LTS, patch version 3.4.2.1+

So this PR is NOT to be merged, since it will break existing Pongo users.

@kikito
Copy link
Copy Markdown
Member

kikito commented Jul 4, 2025

It's unclear whether this is needed or not, but for now I will just convert to draft, and if no one complains, close the PR afterwards.

@kikito kikito marked this pull request as draft July 4, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants