989 khiops raw gui not active despite driver being installed by bruno-at-orange · Pull Request #1008 · KhiopsML/khiops

bruno-at-orange · 2026-04-27T07:13:25Z

fix KHIOPS_RAW_GUI not active despite driver being installed #989
Silence warnings with clang/macOS compiler
- implicit conversion from 'long' to 'double'
- Set but not used [-Wunused-but-set-parameter]
- first argument in call to 'memset' is a pointer to non-trivially copyable type 'Symbol'
Pending warnings in files:
- ~~KWDerivationRule.cpp: Affectations with NULL commented with "Pour eviter le warning" produce a warning.~~
- ~~MHFloatingPointFrequencyTableBuilder::InitializeBins: variable 'cMantissa' set but not used. Weird...~~
- KWGrouperMODLOptimization.cpp: in method EMPostOptimizeGroupsWithGarbage, variable nStart is not used but initialized with RandomInt. It could change the references in LearningTest
- KWDataPreparation/* to avoid difficult conflicts
- KWTest/*
modification of the view generation in order to silence warnings

Important

LearningTest full passed

The method GetLearningRawGuiModeMode() call GetLearningDefaultRawGuiModeMode() Then, it must be called after SetLearningDefaultRawGuiModeMode()

marcboulle

Modifier le générateur de code pour ne pas générer les variables locales inutilisées provoquant un warning.

Méthodes impactées:

TableGenerator::GenerateAttributeViewC
TableGenerator::GenerateAttributeArrayViewC

Code impacté:

ost << "void " << GetArrayViewClassName() << "::EventUpdate(Object* object)"
    << "\n";
ost << "{"
    << "\n";
ost << "\t" << GetModelClassName() << "* editedObject;"
    << "\n";
ost << ""
    << "\n";
ost << "\trequire(object != NULL);"
    << "\n";
ost << ""
    << "\n";
if (GetSuperClassName() != "")
	ost << "\t" << GetArrayViewSuperClassName() << "::EventUpdate(object);\n";
ost << "\teditedObject = cast(" << GetModelClassName() << "*, object);"
    << "\n";
for (nCurrent = 0; nCurrent < GetFieldNumber(); nCurrent++)
{
	att = GetFieldAt(nCurrent);

	if (att->GetVisible() and not att->GetDerived())
	{
		ost << "\teditedObject->Set" << att->GetName() << "("
		    << "Get" << att->GetFieldType() << "ValueAt(\"" << att->GetName() << "\")"
		    << ");"
		    << "\n";
	}
}

ost << ""
    << "\n";
GenerateUserCodeSection(ost, "\t", "Custom update");
ost << "}"

Conditionner la génération de la variable locale (ost << "\t" << GetModelClassName() << "* editedObject;"), et son accès ( ost << "\teditedObject = cast(" << GetModelClassName() << "*, object);" par un nombre de champs non null (if (GetFieldNumber() > 0)).

marcboulle · 2026-04-28T08:53:10Z

 	DTAttributeSelection* attributegenerator;
 	boolean bRegressionWithEqualFreqDiscretization = false;
 	boolean bRegressionWithMODLDiscretization = false;
-	int nBuidTreeNumber;


Utilisé dans le bloc de trace GENERATE_PYTHON_REPORTING_TRACES (ligne 1157).
On ne peut pas supprimer cette variable

j'ai tout mis dans le ifdef GENERATE_PYTHON_REPORTING_TRACES

marcboulle · 2026-04-28T08:58:36Z

 			//	bOk = false;
 			//	break;
 			//}
-			previousSlice = slice;


Plutot que d'enlever cette variable, il faudrait changer le code mort

// if (previousSlice != NULL and previousSlice->CompareLexicographicOrder(slice) >= 0) //{ // AddError("Wrong ordering between " + slice->GetClassLabel() + "s " + // previousSlice->GetObjectLabel() + " and " + slice->GetObjectLabel()); // bOk = false; // break; //}

en

assert(previousSlice == NULL or previousSlice->CompareLexicographicOrder(slice) < 0)

marcboulle · 2026-04-28T09:00:23Z

 	// Memorisation des nombre de modalites, groupes et classes cibles
 	nModalityNumber = kwftSource->GetFrequencyVectorNumber();
 	nGroupNumber = kwftTarget->GetFrequencyVectorNumber();
-	nTargetNumber = kwftSource->GetFrequencyVectorSize();


il n'y a plus et classes dans le commentaire

marcboulle · 2026-04-28T09:00:49Z

@@ -1572,7 +1569,7 @@ void DTGrouperMODL::FastPostOptimizeGroupsWithGarbage(KWFrequencyTable* kwftSour
 	// Memorisation des nombre de modalites, groupes et classes cibles


il n'y a plus et classes dans le commentaire

marcboulle · 2026-04-28T09:01:02Z

@@ -2080,7 +2076,6 @@ void DTGrouperMODL::PostOptimizeGroupsWithGarbageSearch(ObjectArray* oaInitialGr
 	// Memorisation des nombre de modalites, groupes et classes cibles


il n'y a plus et classes dans le commentaire

marcboulle · 2026-04-28T09:44:22Z

-
-	// Acces a la base source
-	sourceDatabase = shared_sourceDatabase.GetPLDatabase();
 	timer.Start();


déplacer cette instruction e,tre le commentaire et la première instruction suivante bOk = bOk and...

marcboulle · 2026-04-28T09:50:47Z

 	SystemFileDriverCreator::RegisterExternalDrivers();

+	// Parametrage du mode d'interface graphique en fonction des drivers de fichiers enregistres
+	SetLearningDefaultRawGuiModeMode(SystemFileDriverCreator::GetExternalDriverNumber());


être plus explicite en passant un booléen en paramètre
SetLearningDefaultRawGuiModeMode(SystemFileDriverCreator::GetExternalDriverNumber() > 0);

marcboulle · 2026-04-28T11:04:04Z

-	lSelectionScorerMemory = ComputeSlaveScorerNecessaryMemory();

 	// La memoire de l'esclave est celle des
 	lSlaveMemory = lLayoutMemory + lTargetValuesMemory + lBinarySliceSetSelfMemory;


J'ai plutôt l'impression qu'il s'agit d'un oubli.
On devrait avoir

lSlaveMemory = lLayoutMemory + lTargetValuesMemory + lBinarySliceSetSelfMemory + lSelectionScorerMemory ;

marcboulle · 2026-04-28T11:06:51Z

 	int nErrorNumber;
 	int i;
 	boolean bOk;
+	boolean bVerbose = false;


changer en const boolean bTrace = false;

marcboulle · 2026-04-28T11:15:55Z

 	require(IsEmpty());

 	bMissingMemory = GetMissingMemory() > 0;
-	bMissingDisk = GetMissingDisk() > 0;


Il ne devrait pas y avoir un message en cas de manque de mémoire disque?

c'est déjà le cas...

marcboulle

LGTM

- warnings 'Set but not used [-Wunused-but-set-parameter]' - warnings for variable uninitialized - warnings: implicit conversion from 'long' to 'double' - warnings: first argument in call to 'memset' is a pointer to non-trivially copyable type 'Symbol' - warning: ignoring duplicate libraries - warning: Unused parameter Silence warning with (void)variable [IA Generated] In C/C++, writing (void)variable means: Convert the expression to type void Discard its value Tell the compiler: this is intentionally unused So for an unused parameter, this pattern avoids warnings like “unused parameter”. Why it helps in your case: variable = NULL writes to the parameter, so compiler can warn “set but not used” (void)variable does not write anything, it only marks the parameter as intentionally consumed Typical use: (void)kwoObject; (void)indexedKeyBlock; It has no runtime effect in practice, it is only for clarity and warning suppression.

When there isn't any attribute, it is not necessary to declare and cast the object. It produces a warning "Set but not used"

bruno-at-orange requested a review from marcboulle April 27, 2026 07:13

bruno-at-orange linked an issue Apr 27, 2026 that may be closed by this pull request

KHIOPS_RAW_GUI not active despite driver being installed #989

Closed

bruno-at-orange force-pushed the 989-khiops_raw_gui-not-active-despite-driver-being-installed branch 3 times, most recently from c7ba60b to 06ea2a7 Compare April 27, 2026 09:00

bruno-at-orange marked this pull request as ready for review April 27, 2026 09:21

Activate Raw GUI mode when drivers are installed

487b41c

The method GetLearningRawGuiModeMode() call GetLearningDefaultRawGuiModeMode() Then, it must be called after SetLearningDefaultRawGuiModeMode()

bruno-at-orange force-pushed the 989-khiops_raw_gui-not-active-despite-driver-being-installed branch 2 times, most recently from 60f8f8a to 1143018 Compare April 28, 2026 07:50

marcboulle requested changes Apr 28, 2026

View reviewed changes

bruno-at-orange requested a review from marcboulle April 29, 2026 08:48

marcboulle approved these changes May 4, 2026

View reviewed changes

bruno-at-orange added 4 commits May 4, 2026 11:36

Remove space character in copyright

cc05136

Modification of the generation of the *View.cpp to silence warning

44cc45c

When there isn't any attribute, it is not necessary to declare and cast the object. It produces a warning "Set but not used"

Silence pending commits

a0775f5

bruno-at-orange force-pushed the 989-khiops_raw_gui-not-active-despite-driver-being-installed branch from e10b111 to a0775f5 Compare May 4, 2026 09:40

bruno-at-orange merged commit afa9342 into main May 4, 2026
29 checks passed

bruno-at-orange deleted the 989-khiops_raw_gui-not-active-despite-driver-being-installed branch May 4, 2026 09:40

		@@ -1572,7 +1569,7 @@ void DTGrouperMODL::FastPostOptimizeGroupsWithGarbage(KWFrequencyTable* kwftSour
		// Memorisation des nombre de modalites, groupes et classes cibles

		@@ -2080,7 +2076,6 @@ void DTGrouperMODL::PostOptimizeGroupsWithGarbageSearch(ObjectArray* oaInitialGr
		// Memorisation des nombre de modalites, groupes et classes cibles

Conversation

bruno-at-orange commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcboulle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcboulle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bruno-at-orange commented Apr 27, 2026 •

edited

Loading