fix(playback): delay replay chunk sends until live chunks settle#81
Merged
DriftN2Forty merged 1 commit intoJun 24, 2026
Merged
Conversation
What changed: - Added a replay chunk send gate in ReplayBlockManager. - Production replay chunks now wait until viewer.isChunkSent(...) reports the matching real server chunk has been sent. - Added a one-refresh grace after first observing the server chunk as sent before sending the replay chunk. - Cleans up the readiness tracking when chunks leave view, restore, discard, or session cleanup runs. - Added regression tests for: - Waiting for isChunkSent + one refresh. - Avoiding stale replay chunk sends after leaving view before the server chunk is ready. - Updated CHANGELOG.md. - Updated docs/ARCHITECTURE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When a replay viewer is teleported far away, replay chunks could be sent before the server finished streaming the real world chunks for that area. If the live chunk packets arrived afterward, they would overwrite the replay chunk overlay, which is especially visible on flat dedicated replay servers where the replay chunks appear to disappear.
This change makes replay chunk application wait until the viewer has already received the matching live server chunk and then waits one more refresh before sending the replay snapshot. That avoids relying on a fixed tick delay while still ensuring replay chunks land after the live chunk stream settles.
Testing
mvn -Dtest=ReplayBlockManagerTest testmvn test