fix(storage): respect MIN_RECORDING_VERSION in replay manifests#79
Merged
DriftN2Forty merged 3 commits intoJun 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VersionUtil.MIN_RECORDING_VERSIONinstead of copying the exact writer version intominimumViewerVersionrecordedWithVersionas the exact plugin build that wrote the replay1.5.0-alpha.1and update tests to useMIN_RECORDING_VERSIONfor current-version roundtripsAGENTS.mdthat replay-format or playback-breaking changes must bumpVersionUtil.MIN_RECORDING_VERSION, including the manual Modrinth alpha lookup step when neededProblem
Alpha-created recordings could be finalized with an overly strict manifest requirement because the archive finalizer wrote the current plugin version into both
recordedWithVersionandminimumViewerVersion.That made recordings created or recovered on prerelease lines look like they required an unrelated stable release, and once prerelease-aware version comparison was fixed, those replays were correctly rejected.
Fix
recordedWithVersion = pluginVersionminimumViewerVersion = VersionUtil.MIN_RECORDING_VERSION1.4.0runtime assumptions so they continue to reflect the maintained compatibility floorTesting
mvn test