Skip to content

Fix iscompressed in zarr extension #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixcremer merged 1 commit into from
Jun 1, 2026
Merged

Fix iscompressed in zarr extension #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ AxisArrays = "0.4"
AxisKeys = "0.2"
DimensionalData = "0.27, 0.28, 0.29, 0.30"
NetCDF = "0.11, 0.12"
Zarr = "0.8, 0.9"
Zarr = "0.10"


[extensions]
Expand Down
6 changes: 4 additions & 2 deletions ext/ZarrExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module ZarrExt
using YAXArrayBase
using Zarr: ZArray, ZGroup, zgroup, zcreate, to_zarrtype, zopen, Compressor, ZipStore
using Zarr: ZArray, ZGroup, zgroup, zcreate, to_zarrtype, zopen, Compressor, ZipStore, NoCompressor, MetadataV2, MetadataV3
import DiskArrays: AbstractDiskArray, DiskArrays, Unchunked, Chunked, GridChunks
using ZipArchives: ZipReader
import YAXArrayBase: YAXArrayBase as YAB
Expand Down Expand Up @@ -74,7 +74,9 @@ YAB.create_empty(::Type{ZarrDataset}, path, gatts=Dict()) = ZarrDataset(zgroup(p
YAB.allow_parallel_write(::ZarrDataset) = true
YAB.allow_missings(::ZarrDataset) = false
YAB.to_dataset(g::ZGroup; kwargs...) = ZarrDataset(g; kwargs...)
YAB.iscompressed(a::ZArray{<:Any,<:Any,<:Compressor}) = true
YAB.iscompressed(a::ZArray) = _iscompressed(a.metadata)
_iscompressed(m::MetadataV3) = !isempty(m.codec.byte_to_byte)
_iscompressed(m::MetadataV2) = !isa(m.compressor, NoCompressor)


#Add ability to read zipped zarrs
Expand Down
Loading