This repository was archived by the owner on Sep 6, 2023. It is now read-only.
use ManualResetEventSlim instead of using Thread.Sleep in a loop#582
Merged
JimBobSquarePants merged 1 commit intoJimBobSquarePants:developfrom May 2, 2017
Merged
Conversation
Owner
|
Thanks for this appreciate it! 👍 BTW that analyzer is very clever. Hopefully you get the appropriate feedback soon! |
Contributor
Author
|
Thanks:) To be clear: My analyzer provides code fixes only if |
Owner
|
Ah cool, Still clever stuff. Something I'd like to look into one day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor change which eliminates anti-pattern of using Thread.Sleep() in a loop. Using Thread.Sleep() in a loop is inefficient because of unnecessary context switches and unnecessary delays that it causes.
I've found this repo by using Google BigQuery when I searched if my code analyzer is useful.
PS. I recommend viewing this PR is a in a tool that handles changes of indentation well (e.g. git plugin for VS2017).
Prerequisites: