Skip to content

test(layout): add empty fallback coverage#6266

Open
sanzzzz-g wants to merge 2 commits into
JhaSourav07:mainfrom
sanzzzz-g:test/layout-empty-fallback
Open

test(layout): add empty fallback coverage#6266
sanzzzz-g wants to merge 2 commits into
JhaSourav07:mainfrom
sanzzzz-g:test/layout-empty-fallback

Conversation

@sanzzzz-g

Copy link
Copy Markdown
Contributor

Description

Fixes #4243

Added isolated empty fallback and edge-case test coverage for app/layout.tsx.

Coverage added

  • verifies layout renders safely with null children
  • verifies layout renders safely with undefined children
  • ensures fallback main container remains stable during empty states
  • validates accessibility skip-link rendering
  • confirms metadata and viewport defaults remain intact
  • ensures no hydration/runtime failures occur during empty rendering

Pillar

  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A (test-only changes)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have started the repo.
  • I have made sure that I have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).

@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

Asset PR Size Base Size Difference Status
static/chunks/2373-[hash].js 41.60 KB 41.88 KB -0.29 KB (-0.68%) 🟢 Improvement
static/chunks/9453-[hash].js 93.37 KB 93.33 KB +0.04 KB (+0.04%) 🔴 Regression

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3708.66 KB 3710.63 KB -1.97 KB (-0.05%)
Total CSS 290.64 KB 290.64 KB 0 B

@Aamod-Dev Aamod-Dev added level:beginner Small changes Usually isolated fixes or simple UI/text updates. type:testing Adding, updating, or fixing tests mentor:Aamod007 labels Jun 22, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GSSoC 2025 Mentor Review — @Aamod007

Labels: level:beginner, type:testing, mentor:Aamod007

Difficulty (beginner): Single test file testing React render resilience with null/undefined children.

Type (testing): Adds empty fallback coverage for root layout. Fixes #4243.

LGTM — good resilience testing for edge cases.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @sanzzzz-g, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:needs-rebase level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 status:blocked This PR is blocked due to a failing CI check. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(Layout-empty-fallback): verify Edge Cases & Empty/Missing Inputs Verification (Variation 1)

3 participants