fix: correct critical bugs in ScoreboardDatabaseManager and Stream cl…#410
Merged
Conversation
…asses - fix: clear() and rebuild()/rebuildAsync() using bare `scoreboard` instead of getScoreboard() - fix: CustomDatabase spreading params correctly to super(...params) - fix: inverted instanceof check in constructor type validation - fix: inverted property-in-object checks across 4 Stream methods - fix: loadAsync() now properly yields between iterations with await null
Updated author and project links, added follow-up changes notes and warnings regarding legacy code.
conmaster2112
approved these changes
May 20, 2026
Collaborator
conmaster2112
left a comment
conmaster2112
left a comment
There was a problem hiding this comment.
This code is from pre-dynamic properties are, where we used scoreboards to save persistent data.
await null hack no longer behaves as used to, await null no longer yields tick execution, so all microtasks has to finish before tick ends. That means async or sync functions has same impact on game freezing when saving large amount of data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct critical bugs in ScoreboardDatabaseManager and Stream classes
scoreboardinstead of getScoreboard()