Add cf2018 config, change all server configs to use javaversion, update readme for those, and add .gitignore#5
Open
carehart wants to merge 3 commits into
Open
Add cf2018 config, change all server configs to use javaversion, update readme for those, and add .gitignore#5carehart wants to merge 3 commits into
carehart wants to merge 3 commits into
Conversation
Author
|
BTW, I caught (only too late) that this PR has in it the same push of a new cf2018 that an earlier (open) PR did. It would be ok to accept that older one and then this (the file's the same). Then the commit for changing them all to use javaVersion changes it yet again. Same for the earlier PR on removing the cfpm commands from CF servers before 2021. This final PR incorporates the same change. (Sorry for the confusion. I had a problem where I'd done the work on 2 computers, each with their own local repo, not synced with each other via my own fork.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in the readme explains the others. And as for the gitignore, it helps us (those who may work on the tool) to not have our snippets and their execution included in the repo/PRs).