Fix valueformalarg literals not having a type#162
Merged
IgorDeepakM merged 7 commits intomasterfrom Apr 28, 2026
Merged
Conversation
There are cases when the literals of a TK_VALUEFORMALARG in typeargs in a nominal type are not typed. This is because the types of method later on might be used and copied despite the nominal types haven't been processed in the expression pass yet. In order to fix this, reify adds an attempt to type and coerce the type value literals. Fixes in the subtype check, now checks the param type instead of the ast_type of the literal in case it hasn't been set yet. In method_call, the return type is run through ast_passes_subtree in order for it to be processed because the type of TK_CALL is being used for several purposes like infer type. Added \allowstruct\ to bypass not allowing structs as type parameters. This annotations can be used together with a type constraint which isn't the case with AnyNoCheck which is a constraint in itself and cannot be used with additional type constaints.
use ast_visit instead of pass_expr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases when the literals of a TK_VALUEFORMALARG in typeargs in a nominal type are not typed. This is because the types of method later on might be used and copied despite the nominal types haven't been processed in the expression pass yet.
In order to fix this, reify adds an attempt to type and coerce the type value literals. Fixes in the subtype check, now checks the param type instead of the ast_type of the literal in case it hasn't been set yet. In method_call, the return type is run through ast_passes_subtree in order for it to be processed because the type of TK_CALL is being used for several purposes like infer type.
Added \allowstruct\ to bypass not allowing structs as type parameters. This annotations can be used together with a type constraint which isn't the case with AnyNoCheck which is a constraint in itself and cannot be used with additional type constaints.