Skip to content

[codex] fix macos go test portability#2523

Open
ianalloway wants to merge 1 commit into
IceWhaleTech:mainfrom
ianalloway:codex/macos-go-test-portability
Open

[codex] fix macos go test portability#2523
ianalloway wants to merge 1 commit into
IceWhaleTech:mainfrom
ianalloway:codex/macos-go-test-portability

Conversation

@ianalloway

Copy link
Copy Markdown

Summary

  • split Linux-only Samba mount calls behind Linux build tags
  • add non-Linux mount stubs that return an explicit unsupported-platform error
  • add a Darwin route callback stub and skip the /proc/net port test off Linux

Why

A fresh macOS checkout could not run go test ./... after go generate because Linux mount APIs and /proc-backed health tests were compiled on Darwin.

Validation

  • go generate ./...
  • go test ./...

Copilot AI review requested due to automatic review settings June 27, 2026 16:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants