Removing dispatch async calls for certain blocks of code

ssathy2 · ssathy2 · commit 5de3bc94c6fe · 2021-07-08T10:15:36.000-05:00
diff --git a/IFTTT SDK/ConnectionsMonitor.swift b/IFTTT SDK/ConnectionsMonitor.swift
@@ -64,9 +64,7 @@ class ConnectionsMonitor: SynchronizationSubscriber {
         let startingCount = connections.count
         
         let completionOperation = BlockOperation {
-            DispatchQueue.main.async {
-                completion(self.connectionsRegistry.getConnectionsCount() == startingCount, error)
-            }
+            completion(self.connectionsRegistry.getConnectionsCount() == startingCount, error)
         }
         
         let credentialProvider = UserAuthenticatedRequestCredentialProvider()
diff --git a/IFTTT SDK/ConnectionsSynchronizer.swift b/IFTTT SDK/ConnectionsSynchronizer.swift
@@ -296,9 +296,7 @@ private class NativeServicesCoordinator {
     }
     
     func processConnectionUpdate(_ updates: Set<Connection.ConnectionStorage>) {
-        DispatchQueue.main.async {
-            self.permissionsRequestor.processUpdate(with: updates)
-            self.locationService.updateRegions(from: updates)
-        }
+        permissionsRequestor.processUpdate(with: updates)
+        locationService.updateRegions(from: updates)
     }
 }
diff --git a/IFTTT SDK/LocationService.swift b/IFTTT SDK/LocationService.swift
@@ -118,6 +118,7 @@ class RegionEventsSessionManager {
             if retryCount < numberOfRetries {
                 let count = retryCount + 1
                 ConnectButtonController.synchronizationLog("Failed to upload region events: \(events). Will retry \(numberOfRetries - retryCount) more times.")
+                
                 DispatchQueue.main.asyncAfter(deadline: .now() + self.exponentialBackoffTiming(for: count)) {
                     self.upload(events: events,
                                 credentialProvider: credentialProvider,
diff --git a/SDKHostApp/AppDelegate.swift b/SDKHostApp/AppDelegate.swift
@@ -2,7 +2,6 @@
 //  AppDelegate.swift
 //  SDKHostApp
 //
-//  Created by Siddharth Sathyam on 12/11/20.
 //  Copyright © 2020 IFTTT. All rights reserved.
 //
 
diff --git a/SDKHostApp/ContentView.swift b/SDKHostApp/ContentView.swift
@@ -2,7 +2,6 @@
 //  ContentView.swift
 //  SDKHostApp
 //
-//  Created by Siddharth Sathyam on 12/11/20.
 //  Copyright © 2020 IFTTT. All rights reserved.
 //
 
diff --git a/SDKHostApp/SceneDelegate.swift b/SDKHostApp/SceneDelegate.swift
@@ -2,7 +2,6 @@
 //  SceneDelegate.swift
 //  SDKHostApp
 //
-//  Created by Siddharth Sathyam on 12/11/20.
 //  Copyright © 2020 IFTTT. All rights reserved.
 //
 
diff --git a/SDKHostAppTests/ArrayHelpersTests.swift b/SDKHostAppTests/ArrayHelpersTests.swift
@@ -2,7 +2,6 @@
 //  ArrayHelpersTests.swift
 //  SDKHostAppTests
 //
-//  Created by Siddharth Sathyam on 12/14/20.
 //  Copyright © 2020 IFTTT. All rights reserved.
 //
 
diff --git a/SDKHostAppUITests/SDKHostAppUITests.swift b/SDKHostAppUITests/SDKHostAppUITests.swift
@@ -2,7 +2,6 @@
 //  SDKHostAppUITests.swift
 //  SDKHostAppUITests
 //
-//  Created by Siddharth Sathyam on 12/11/20.
 //  Copyright © 2020 IFTTT. All rights reserved.
 //
 

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,7 @@ class ConnectionsMonitor: SynchronizationSubscriber {`
`64`	`64`	`let startingCount = connections.count`
`65`	`65`
`66`	`66`	`let completionOperation = BlockOperation {`
`67`		`- DispatchQueue.main.async {`
`68`		`- completion(self.connectionsRegistry.getConnectionsCount() == startingCount, error)`
`69`		`- }`
	`67`	`+ completion(self.connectionsRegistry.getConnectionsCount() == startingCount, error)`
`70`	`68`	`}`
`71`	`69`
`72`	`70`	`let credentialProvider = UserAuthenticatedRequestCredentialProvider()`
Original file line number	Diff line number	Diff line change
`@@ -296,9 +296,7 @@ private class NativeServicesCoordinator {`
`296`	`296`	`}`
`297`	`297`
`298`	`298`	`func processConnectionUpdate(_ updates: Set<Connection.ConnectionStorage>) {`
`299`		`- DispatchQueue.main.async {`
`300`		`- self.permissionsRequestor.processUpdate(with: updates)`
`301`		`- self.locationService.updateRegions(from: updates)`
`302`		`- }`
	`299`	`+ permissionsRequestor.processUpdate(with: updates)`
	`300`	`+ locationService.updateRegions(from: updates)`
`303`	`301`	`}`
`304`	`302`	`}`