Removing logic which delayed syncs by 0.1 seconds. This works well when the app is in the foreground but when the app is in the background, the sync run closure never runs

Author: ssathy2

Examples/Examples.xcodeproj/project.pbxproj

@@ -329,7 +329,9 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
+				CODE_SIGN_STYLE = Manual;
 				CURRENT_PROJECT_VERSION = 35;
+				DEVELOPMENT_TEAM = 8SV2G8GQ6K;
 				INFOPLIST_FILE = GroceryExpress/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 10.0;
 				LD_RUNPATH_SEARCH_PATHS = (
@@ -338,6 +340,7 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = com.ifttt.sdk.example;
 				PRODUCT_NAME = "$(TARGET_NAME)";
+				PROVISIONING_PROFILE_SPECIFIER = "SDK Example Dev";
 				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};
@@ -349,7 +352,7 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Manual;
 				CURRENT_PROJECT_VERSION = 35;
-				DEVELOPMENT_TEAM = "";
+				DEVELOPMENT_TEAM = 8SV2G8GQ6K;
 				INFOPLIST_FILE = GroceryExpress/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 10.0;
 				LD_RUNPATH_SEARCH_PATHS = (
@@ -358,7 +361,7 @@
 				);
 				PRODUCT_BUNDLE_IDENTIFIER = com.ifttt.sdk.example;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				PROVISIONING_PROFILE_SPECIFIER = "";
+				PROVISIONING_PROFILE_SPECIFIER = "SDK Example Dev";
 				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};

IFTTT SDK/LocationService.swift

@@ -186,8 +186,6 @@ final class LocationService: NSObject, SynchronizationSubscriber {
     private let sessionManager: RegionEventsSessionManager
     /// The `EventPublisher<SynchronizationTriggerEvent>` that handles publishing synchronization events to listeners
     private let regionEventTriggerPublisher: EventPublisher<SynchronizationTriggerEvent>
-    /// Determines whether or not a 0.1 second delay should be applied before publishing synchronization events
-    private let applyDelayOnSyncTrigger: Bool
 
     struct Constants {
         static let SanityThreshold = 20
@@ -201,21 +199,18 @@ final class LocationService: NSObject, SynchronizationSubscriber {
     ///     - connectionsRegistry: An instance of `ConnectionsRegistry` that determines which connections are currently being monitored by the SDK.
     ///     - sessionManager: An instance of `RegionEventsSessionManager` that uploads region events to the backend.
     ///     - eventPublisher: An instance of `EventPublisher<SynchronizationTriggerEvent>` that handles publishing sync events to listeners.
-    ///     - applyDelayOnSyncTrigger: Determines whether or not a 0.1 second delay should be applied to trigger syncs. Defaults to `true`.
     /// - Returns: An initialized instance of `LocationService`.
     init(regionsMonitor: RegionsMonitor,
          regionEventsRegistry: RegionEventsRegistry,
          connectionsRegistry: ConnectionsRegistry,
          sessionManager: RegionEventsSessionManager,
-         eventPublisher: EventPublisher<SynchronizationTriggerEvent>,
-         applyDelayOnSyncTrigger: Bool = true) {
+         eventPublisher: EventPublisher<SynchronizationTriggerEvent>) {
         self.regionsMonitor = regionsMonitor
         self.regionEventsRegistry = regionEventsRegistry
         self.connectionsRegistry = connectionsRegistry
         self.sessionManager = sessionManager
         self.regionEventTriggerPublisher = eventPublisher
 
-        self.applyDelayOnSyncTrigger = applyDelayOnSyncTrigger
         super.init()
     }
 
@@ -275,21 +270,14 @@ final class LocationService: NSObject, SynchronizationSubscriber {
         let event = RegionEvent(kind: kind, triggerSubscriptionId: region.identifier)
         regionEventsRegistry.add(event)
 
-        let closure = {
-            let event = SynchronizationTriggerEvent(source: .regionsUpdate,
-                                                    completionHandler: nil)
-            
-            self.regionEventTriggerPublisher.onNext(event)
-            
-            if let backgroundTaskIdentifier = backgroundTaskIdentifier, backgroundTaskIdentifier != UIBackgroundTaskIdentifier.invalid {
-                UIApplication.shared.endBackgroundTask(backgroundTaskIdentifier)
-            }
-        }
-
-        if applyDelayOnSyncTrigger {
-            DispatchQueue.main.asyncAfter(deadline: .now() + 0.1, execute: closure)
-        } else {
-            closure()
+        let triggerEvent = SynchronizationTriggerEvent(source: .regionsUpdate,
+                                                       completionHandler: nil)
+        
+        self.regionEventTriggerPublisher.onNext(triggerEvent)
+        
+        if let backgroundTaskIdentifier = backgroundTaskIdentifier,
+           backgroundTaskIdentifier != UIBackgroundTaskIdentifier.invalid {
+            UIApplication.shared.endBackgroundTask(backgroundTaskIdentifier)
         }
     }
 

SDKHostAppTests/LocationServiceTests.swift

@@ -42,8 +42,7 @@ class LocationServiceTests: XCTestCase {
                                           connectionsRegistry: connectionsRegistry,
                                           sessionManager: .init(networkController: regionEventsController,
                                                                 regionEventsRegistry: regionEventsRegistry),
-                                          eventPublisher: eventPublisher,
-                                          applyDelayOnSyncTrigger: false)
+                                          eventPublisher: eventPublisher)
     }
 
     override func tearDown() {