Skip to content

Reduce redundant CloudFront invalidation paths #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlospolop wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Reduce redundant CloudFront invalidation paths #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build_master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,9 @@ jobs:

- name: Invalidate CloudFront HTML and SEO assets
run: |
# /en/* covers /en/robots.txt and /en/sitemap.xml; only invalidate
# root SEO files separately.
aws cloudfront create-invalidation \
--distribution-id "${{ secrets.CLOUDFRONT_DISTRIBUTION_ID }}" \
--paths "/en/*" "/robots.txt" "/en/robots.txt" "/sitemap.xml" "/en/sitemap.xml"
--paths "/en/*" "/robots.txt" "/sitemap.xml"

4 changes: 3 additions & 1 deletion .github/workflows/translate_all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,9 @@ jobs:
shell: bash
run: |
set -euo pipefail
paths=("/$BRANCH/*" "/$BRANCH/sitemap.xml")
# The wildcard already invalidates the language sitemap, so avoid
# paying for a redundant explicit /$BRANCH/sitemap.xml path.
paths=("/$BRANCH/*")
if [ "${{ steps.root_sitemap.outputs.changed }}" = "true" ]; then
paths+=("/sitemap.xml")
fi
Expand Down