Remove focus outline for links and buttons in navigation (7.1)#26519
Draft
graylog-internal-actions-access[bot] wants to merge 1 commit into
Draft
Remove focus outline for links and buttons in navigation (7.1)#26519graylog-internal-actions-access[bot] wants to merge 1 commit into
7.1)#26519graylog-internal-actions-access[bot] wants to merge 1 commit into
Conversation
* Remove focus outline for links and buttons in navigation * Add changelog entry --------- Co-authored-by: Dennis Oelkers <dennis@graylog.com> (cherry picked from commit e903465)
graylog-internal-actions-access
Bot
requested review from
dennisoelkers and
linuspahl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #26504 to
7.1.Description
Navbar links and buttons no longer keep a focus ring stuck on them after a mouse click. The rule removes the outline only for pointer focus
:focus:not(:focus-visible), so the focus ring still appears for keyboard navigation.Switching the behavior to
:focus-visibleremoves the lingering ring for mouse users while preserving it for keyboard users too.Motivation and Context
An easy fix that was easy to resolve.
#26503
How Has This Been Tested?
Manually, on a local dev stack (Graylog
7.2.0-SNAPSHOT, Chromium):Screenshots (if appropriate):
Types of changes
Checklist: