Skip to content

add event type to Badge onClick handler#26517

Merged
dennisoelkers merged 1 commit into
masterfrom
refactoring/add-e-type-to-Badge-onClick-hanler
Jul 1, 2026
Merged

add event type to Badge onClick handler#26517
dennisoelkers merged 1 commit into
masterfrom
refactoring/add-e-type-to-Badge-onClick-hanler

Conversation

@maxiadlovskii

@maxiadlovskii maxiadlovskii commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

In some cases, when we add an onClick handler to Badge, we need to add e.stopPropagation(). In the current onClick type implementation, we have nothing in the callback parameters. That causes a TS error.
like here https://github.com/Graylog2/graylog-plugin-enterprise/pull/14636/changes#diff-fc06d32a631b7c264e25164ede49a403aeb159714639064b43d7943cb194be8e
To avoid this we have to add this type to onClick callback prameter

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

/nocl

@maxiadlovskii maxiadlovskii requested a review from a team June 30, 2026 11:43
@dennisoelkers dennisoelkers merged commit 2f44614 into master Jul 1, 2026
37 checks passed
@dennisoelkers dennisoelkers deleted the refactoring/add-e-type-to-Badge-onClick-hanler branch July 1, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants