add event type to Badge onClick handler#26517
Merged
dennisoelkers merged 1 commit intoJul 1, 2026
Merged
Conversation
dennisoelkers
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some cases, when we add an onClick handler to Badge, we need to add e.stopPropagation(). In the current onClick type implementation, we have nothing in the callback parameters. That causes a TS error.
like here https://github.com/Graylog2/graylog-plugin-enterprise/pull/14636/changes#diff-fc06d32a631b7c264e25164ede49a403aeb159714639064b43d7943cb194be8e
To avoid this we have to add this type to onClick callback prameter
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/nocl