Propagate scope for referenced search filters during content pack installation#26508
Merged
ryan-carroll-graylog merged 5 commits intoJul 1, 2026
Merged
Conversation
kingzacko1
approved these changes
Jul 1, 2026
danotorrey
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the scope from the top level Search Filter objects for the inline copies during content pack installation.
This keeps parity between the top level search filter objects and the inline entity copies, specifically when the scope is not included at time of export (Illuminate bundles).
For existing mismatched filters a migration has been added in https://github.com/Graylog2/graylog-plugin-enterprise/pull/14647
Motivation and Context
This was causing illuminate installed entities that reference search filters to have the inline copies of ILLUMINATE scoped search filters shown as DEFAULT. E.g. an ILLUMINATE delivered/scoped event definition with filter would be installed with ED and filter correctly ILLUMINATE scoped, but inline filter copy on the ED was DEFAULT.
This interfered with Event definition filter scope immutability checks.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: