Add Edit input button to the Input Diagnosis page#26491
Merged
Conversation
gally47
requested changes
Jun 30, 2026
gally47
left a comment
Contributor
There was a problem hiding this comment.
Looking good, but the Input Diagnosis page is not picking up the input updates like Title edit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing an input was only reachable via the "Edit input" item buried in
each row's More menu on the inputs overview. Clicking an input name opens
the Input Diagnosis page, which had no edit affordance, making a basic
action hard to discover.
Add an "Edit input" button next to the diagnosis tab control that opens
the existing edit modal. The action reuses the existing InputForm modal,
the updateInput mutation, telemetry events, and the same permission gate
(inputs:edit + input_types:create) as the overview row action.
/nocl
fix #25430
Types of changes
Checklist: