chore(deps): update dependency google/cloud-logging to v2#2208
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the google/cloud-logging dependency to version ^2.0 in composer.json. Feedback indicates that this major version bump introduces breaking changes in the structure of log entry data, specifically changing payload keys from camelCase to snake_case, which will cause deployment tests to fail. It is recommended to update the test logic to use version-agnostic getter methods and to upgrade the google/auth dependency to at least ^1.18 to ensure compatibility.
| "require-dev": { | ||
| "google/auth": "^1.14", | ||
| "google/cloud-logging": "^1.21" | ||
| "google/cloud-logging": "^2.0" |
There was a problem hiding this comment.
Upgrading to google/cloud-logging v2.0.0 introduces breaking changes that will cause the deployment tests to fail. In v2, the Entry::info() method returns an array with snake_case keys (matching the underlying protobuf fields) instead of the camelCase keys used in v1. Specifically, the check for isset($info['textPayload']) in functions/firebase_remote_config/test/DeployTest.php (line 117) will fail because the key is now text_payload. Since these tests are not run by the CI system (as noted in the file header), this breakage might go unnoticed. You should update the test code to use the getter method $log->textPayload(), which is compatible with both versions, or update the array key access to text_payload. Additionally, google/cloud-logging v2.0.0 requires google/auth version ^1.18; consider updating line 12 to match this requirement.
This PR contains the following updates:
^1.21→^2.0Release Notes
googleapis/google-cloud-php-logging (google/cloud-logging)
v2.0.0: google/cloud-logging v2.0.0Compare Source
Bug Fixes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.