Skip to content

chore(deps): update dependency google/cloud-logging to v2#2208

Open
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
renovate-bot:renovate/functions-firebase_remote_config-google-cloud-logging-2.x
Open

chore(deps): update dependency google/cloud-logging to v2#2208
renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
renovate-bot:renovate/functions-firebase_remote_config-google-cloud-logging-2.x

Conversation

@renovate-bot
Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
google/cloud-logging ^1.21^2.0 age confidence

Release Notes

googleapis/google-cloud-php-logging (google/cloud-logging)

v2.0.0: google/cloud-logging v2.0.0

Compare Source

Bug Fixes

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team as code owners April 29, 2026 18:05
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2026
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Apr 29, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google/cloud-logging dependency to version ^2.0 in composer.json. Feedback indicates that this major version bump introduces breaking changes in the structure of log entry data, specifically changing payload keys from camelCase to snake_case, which will cause deployment tests to fail. It is recommended to update the test logic to use version-agnostic getter methods and to upgrade the google/auth dependency to at least ^1.18 to ensure compatibility.

"require-dev": {
"google/auth": "^1.14",
"google/cloud-logging": "^1.21"
"google/cloud-logging": "^2.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading to google/cloud-logging v2.0.0 introduces breaking changes that will cause the deployment tests to fail. In v2, the Entry::info() method returns an array with snake_case keys (matching the underlying protobuf fields) instead of the camelCase keys used in v1. Specifically, the check for isset($info['textPayload']) in functions/firebase_remote_config/test/DeployTest.php (line 117) will fail because the key is now text_payload. Since these tests are not run by the CI system (as noted in the file header), this breakage might go unnoticed. You should update the test code to use the getter method $log->textPayload(), which is compatible with both versions, or update the array key access to text_payload. Additionally, google/cloud-logging v2.0.0 requires google/auth version ^1.18; consider updating line 12 to match this requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants