Feature: oft adapter step3 - deploy script and test#11
Merged
Conversation
…acts, including enabling hardhat-deploy and adding new network configurations for CELO and XDC
… management structures, and add deployment and configuration scripts for cross-chain functionality
…C network, enhance GoodDollarOFTAdapter with upgrade authorization event, and modify deployment scripts for improved functionality
…ant fee deduction details
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @blueogin, your pull request is larger than the review limit of 150000 diff characters
sirpy
requested changes
Feb 2, 2026
| echo "" | ||
|
|
||
| # Step 7: Test bridge (optional, last step) | ||
| if [ "$SKIP_BRIDGE_TEST" != "true" ]; then |
Contributor
There was a problem hiding this comment.
should be separated into a different script. ( a hardhat script)
sirpy
reviewed
Feb 2, 2026
… unused dependencies in bridge-contracts
Feature: oft adapter step3 - deploy script and test
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…nd to transparent in GoodDollarOFTAdapter and deployment script
…pts to reference new deployment file
…nd update set-minter-burner-limits script to utilize new config
…t for cleaner implementation
…and integrating IMessagePassingBridge for limit management
sirpy
requested changes
Feb 4, 2026
…code clarity and reduce dependencies
…te request approval mechanism to use bytes32 IDs, and implement request ID generation for improved limit management
… MinterBurner contracts
…oved clarity, implement request approval checks, and enforce limits on sending and receiving functions
…8.9 with optimizer settings and modify LayerZero config to reference the correct deployment file
…zation for enhanced fee management
…ove legacy deployment script; add set-oft-operator script for DAO governance integration
…across deployment scripts, tests, and documentation for consistency and clarity in cross-chain token management
Collaborator
Author
|
Hi @sirpy |
Collaborator
Author
|
@sirpy |
…apter and GoodDollarOFTMinterBurner contracts to prevent zero address assignments, enhancing contract security and reliability
Contributor
|
@copilot please audit the contracts and also review the deployment scripts |
sirpy
approved these changes
Apr 19, 2026
…e, use avatar as feeRecipient, clean up dead code Agent-Logs-Url: https://github.com/GoodDollar/GoodBridge/sessions/ec1dcb51-cab6-414e-8579-666c2c266a65 Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>
…apter Agent-Logs-Url: https://github.com/GoodDollar/GoodBridge/sessions/ec1dcb51-cab6-414e-8579-666c2c266a65 Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>
Contributor
Audit completed (commit 47271d8). Here are the findings: GoodDollarOFTAdapter.sol bugs fixed:
deployOFT.ts fix: set-bridge-limits.ts cleanup: No issues found in GoodDollarOFTMinterBurner.sol. Access control, pause/unpause, and operator management are correctly restricted to the DAO avatar. Other items reviewed (no changes needed):
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
@blueogin please verify the AI fixes, does the decimals check need an alternative? |
Contributor
|
@copilot create the copilot-setup-steps.yml file so you can run hardhat correctly |
…mpilers Agent-Logs-Url: https://github.com/GoodDollar/GoodBridge/sessions/5e3a13af-7cc1-4835-8a87-d11a95264e12 Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>
Contributor
Created
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
Author
|
@sirpy |
sirpy
requested changes
Apr 28, 2026
| # Use the bundled Yarn from the repository (.yarn/releases/yarn-4.6.0.cjs) | ||
| # so the correct version is always used without relying on corepack downloads. | ||
| - name: Install root dependencies | ||
| run: node .yarn/releases/yarn-4.6.0.cjs install |
Collaborator
Author
There was a problem hiding this comment.
I will change copilot-setup-steps.yml to use yarn
|
|
||
| # bridge-contracts uses nodeLinker: node-modules (its own .yarnrc.yml) while the root | ||
| # uses PnP, so the workspace needs its own node_modules populated explicitly. | ||
| - name: Install bridge-contracts node_modules |
Contributor
There was a problem hiding this comment.
what is he talking about pnpm?
why does it need to install bridge-contracts? thats the current source code its working on
| # are blocked by the agent's network firewall. | ||
| - name: Pre-download Solidity compilers | ||
| working-directory: packages/bridge-contracts | ||
| run: node_modules/.bin/hardhat compile |
Contributor
There was a problem hiding this comment.
why not simply yarn hardhat compile
Contributor
|
@blueogin did you code review the AI fixes? |
…d streamline dependency installation
Collaborator
Author
|
@sirpy yes - I reviewed the code generated by AI, but I missed the changes related to GitHub Actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the deployment scripts and testing infrastructure for the GoodDollar OFT (Omnichain Fungible Token) adapter system. The implementation enables cross-chain bridging of GoodDollar tokens between XDC and CELO networks using LayerZero's OFT protocol.
About #7
How Has This Been Tested?
https://layerzeroscan.com/tx/0x3575146c0e395d46b4a3e09ec3ae79e1005ea6d4461765d6dc19d6aebed512bb
https://layerzeroscan.com/tx/0xa267c36a25337ea8d45d83de83a3e83a291ba4d2eaf0fd0393d365faf3c078e8
Checklist: