Skip to content

Commit ab569b5

Browse files
author
SuiYue-2308
committed
remove lowMemory which causes the error when specifying readClass.outputDir
1 parent 8833e6d commit ab569b5

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

R/bambu-processReads.R

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,16 +106,12 @@ bambu.processReads <- function(reads, annotations, genomeSequence,
106106
if (!is.null(readClass.outputDir)) {
107107
for(i in seq_along(readClassList)){
108108
readClassFile <- "combinedSamples"
109-
if(lowMemory){
110-
readClassFile <- metadata(readClassList[[i]])$sampleNames
111-
}
112109
readClassFile <- BiocFileCache::bfcnew(BiocFileCache::BiocFileCache(
113110
readClass.outputDir, ask = FALSE),
114111
paste0(readClassFile,"_readClassSe"), ext = ".rds")
115112
saveRDS(readClassList[[i]], file = readClassFile)
116113
readClassList[[i]] <- readClassFile
117114
}
118-
119115
}
120116
#TODO don't output list, current there because discovery needs it
121117
return(readClassList)

R/bambu.R

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@
138138
bambu <- function(reads, annotations = NULL, genome = NULL, NDR = NULL,
139139
mode = NULL, opt.discovery = NULL, opt.em = NULL, rcOutDir = NULL, discovery = TRUE,
140140
assignDist = TRUE, quant = TRUE, stranded = FALSE, ncore = 1, yieldSize = NULL,
141-
trackReads = FALSE, returnDistTable = FALSE, lowMemory = FALSE,
141+
trackReads = FALSE, returnDistTable = FALSE,
142142
fusionMode = FALSE, verbose = FALSE, demultiplexed = FALSE, spatial = NULL, quantData = NULL,
143143
sampleNames = NULL, cleanReads = FALSE, dedupUMI = FALSE, barcodesToFilter = NULL, clusters = NULL,
144144
processByChromosome = FALSE, processByBam = TRUE) {
@@ -165,9 +165,6 @@ bambu <- function(reads, annotations = NULL, genome = NULL, NDR = NULL,
165165
returnDistTable <- TRUE
166166
}
167167
}
168-
if(lowMemory)
169-
message("lowMemory has been deprecated and split into processByChromosome and processByBam. Please see Documentation")
170-
171168
if(is.null(annotations)){
172169
annotations <- GRangesList()
173170
} else {

0 commit comments

Comments
 (0)