Skip to content

Commit 39f1f78

Browse files
committed
fix: align GENEID order for transcriptToGeneExpression(se) and metadata(se)$incompatibleCounts
1 parent 1482373 commit 39f1f78

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

R/readWrite.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ writeBambuOutput <- function(se, path, prefix = "", outputExtendedAnno = TRUE,
4040
feature='transcript',outdir, prefix)
4141
print(d)
4242
}
43-
seGene <- transcriptToGeneExpression(se)
44-
writeCountsOutput(seGene, varname='counts', feature='gene',outdir, prefix)
4543
#write incompatible counts
4644
if(!is.null(metadata(se)$incompatibleCounts)){
47-
estimates <- metadata(se)$incompatibleCounts[rownames(seGene), , drop = FALSE]
45+
estimates <- metadata(se)$incompatibleCounts
4846
estimatesfn <- paste(transcript_gtffn, "incompatibleCounts.mtx", sep = "")
4947
Matrix::writeMM(estimates, estimatesfn)
5048
}
49+
seGene <- transcriptToGeneExpression(se)
50+
writeCountsOutput(seGene, varname='counts', feature='gene',outdir, prefix)
5151
#utils::write.table(paste0(colnames(se), "-1"), file = paste0(outdir, "barcodes.tsv"), quote = FALSE, row.names = FALSE, col.names = FALSE)
5252
#R.utils::gzip(paste0(outdir, "barcodes.tsv"))
5353
txANDGenes <- data.table(as.data.frame(rowData(se))[,c("TXNAME","GENEID")])

R/transcriptToGeneExpression.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ transcriptToGeneExpression <- function(se) {
1515
runnames <- colnames(counts)[-1]
1616
rowDataSe <- as.data.table(rowData(se))
1717

18-
counts = fac2sparse(rowData(se)$GENEID) %*% counts
18+
counts = fac2sparse(factor(rowData(se)$GENEID, levels = unique(rowData(se)$GENEID))) %*% counts
1919
if(!is.null(metadata(se)$incompatibleCounts)){
2020
incompatibleCounts <- metadata(se)$incompatibleCounts
2121
if("nonuniqueCounts" %in% names(metadata(se))){

0 commit comments

Comments
 (0)