fix(anti-cheat): Resolve EAC callback use-after-free race condition#508
Open
ahmedheiba210 wants to merge 1 commit into
Open
fix(anti-cheat): Resolve EAC callback use-after-free race condition#508ahmedheiba210 wants to merge 1 commit into
ahmedheiba210 wants to merge 1 commit into
Conversation
ahmedheiba210
changed the title
ahmedheiba210
changed the title
ahmedheiba210
force-pushed
the
fix/eac-callback-uaf
branch
from
ba80200 to
fb3ee3a
Compare
ahmedheiba210
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the four Set*Callback registrations out of LoadPlugin into a new
RegisterHostCallbacks() helper, guarded by IsPluginLoaded(). Call this
helper once from LoadPlugin and again at the top of BeginSession().
Call ClearAllHostCallbacks() in EndSession() immediately after the
plugin's own EndSession to prevent a race condition during lobby teardown.
This flushes in-flight worker-thread callbacks and nulls pointers before
LeaveCurrentLobby() frees the lobby mesh.
Retain begin/end idempotency and the atomic session-active guard. The
guard protects against shipped DLLs that lack ClearAllHostCallbacks.