feat(website): predefined COVID variant signatures from collections (W-ASAP)#1229
Draft
fhennig wants to merge 5 commits into
Draft
feat(website): predefined COVID variant signatures from collections (W-ASAP)#1229fhennig wants to merge 5 commits into
fhennig wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment was marked as outdated.
This comment was marked as outdated.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fhennig
force-pushed
the
feat/predefined-wasap-covid-variants
branch
from
ef0f352 to
8246e5f
Compare
…edefined variants Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bobox Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fhennig
changed the title
…Type explicit Replace the WasapVariantComputedFilter | WasapVariantPredefinedFilter discriminated union with a single flat WasapVariantFilter type (consistent with WasapUntrackedFilter), removing the need to pass computedDefaults to VariantExplorerFilter. Also moves SignatureType to wasapPageConfig and makes newMutationsOnly optional (undefined = false). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fhennig
force-pushed
the
feat/predefined-wasap-covid-variants
branch
from
08a33ce to
160cebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for predefined variant signatures in the W-ASAP Variant Explorer mode, as an alternative to computing signatures from clinical sequences. For COVID, these come from a configured collections source (filtered by user ID, organism, and a tag in the description).
Summary
predefinedVariantsSourceconfig toWasapPageConfigspecifying where to fetch predefined variant collections from (userId, organism, tag, label)getCollectionSummariesand exposes them in a downshift autocomplete combobox in the filter panelWasapVariantFilterwith asignatureTypefield ('computed'|'predefined') and predefined-specific fields (collectionId,newMutationsOnly); serialised to/from URLsignatureTypedefaults to'computed'and is omitted from the URL for backwards compatibility with existing bookmarksWasapUntrackedFilter), removing the need to passcomputedDefaultsthrough the component treeSignatureTypetowasapPageConfig.tsalongside all other WASAP typessignatureType: 'predefined'is stubbed with a TODO (not yet implemented)Screenshot
PR Checklist