Skip to content

Fix Brake Pedal Percentage On ECU#493

Merged
dchansen06 merged 2 commits into
mainfrom
FixPedals
May 29, 2026
Merged

Fix Brake Pedal Percentage On ECU#493
dchansen06 merged 2 commits into
mainfrom
FixPedals

Conversation

@dchansen06
Copy link
Copy Markdown
Contributor

Brake Percentage

Problem and Scope

Brake percent function ignored min/max on BSE signal

Description

Return actual brake percentage when using BSE off of min/max

Gotchas and Limitations

Needs calibration

Testing

  • HOOTL testing
  • HITL testing
  • Human tested

Testing Details

Looks better

Larger Impact

None

Additional Context and Ticket

Found during testing

@dchansen06 dchansen06 self-assigned this May 24, 2026
@dchansen06 dchansen06 added Documentation Improvements or additions to documentation Enhancement New feature or request 1 URGENT Urgent issue that needs a quick action and resolution Small Fry Something that is small, could include bug fixes or smaller changes Sensors Something involved with or related to sensors Boards Related to or involving any physical boards Bug Something is doing a thing but doing it wrong or otherwise incorrectly labels May 24, 2026
@dchansen06 dchansen06 added this to the GR26 milestone May 24, 2026
@dchansen06 dchansen06 marked this pull request as ready for review May 24, 2026 08:18
@dchansen06 dchansen06 requested a review from kzwicker as a code owner May 24, 2026 08:18
@dchansen06 dchansen06 changed the title Fix Brake Pedal On ECU Fix Brake Pedal Percentage On ECU May 24, 2026
@dchansen06 dchansen06 force-pushed the FixPedals branch 2 times, most recently from 55877c7 to 6c5398d Compare May 27, 2026 00:21
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
Copy link
Copy Markdown
Contributor

@khoulihan27 khoulihan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dchansen06 dchansen06 merged commit 9cc04e4 into main May 29, 2026
32 checks passed
@dchansen06 dchansen06 deleted the FixPedals branch May 29, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 URGENT Urgent issue that needs a quick action and resolution Boards Related to or involving any physical boards Bug Something is doing a thing but doing it wrong or otherwise incorrectly Documentation Improvements or additions to documentation Enhancement New feature or request Sensors Something involved with or related to sensors Small Fry Something that is small, could include bug fixes or smaller changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants