Worked around iOS mobile Safari browser bug which leaks memory…#365
Open
ateamlunchbox wants to merge 1 commit intoGalleriaJS:masterfrom
Open
Worked around iOS mobile Safari browser bug which leaks memory…#365ateamlunchbox wants to merge 1 commit intoGalleriaJS:masterfrom
ateamlunchbox wants to merge 1 commit intoGalleriaJS:masterfrom
Conversation
…memory if <img> tags are removed from the DOM without having their 'src' attribute first set to ''.
|
hm, my bigger galleries are still crashing on IOS. Older Versions of Gallery can serve bigger galleries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if![]()
tags are removed from the DOM without having their 'src' attribute first set to ''.
I love the library and used it to build a personal photo gallery with > 600 images in native iPad format (2048x1536). It would cycle through around 115 images and then Safari would crash. I did some digging and found a known issue with a solution (see comments in my patch).
The patched code seems to be working fine: I have been running my single-page photo web app for hours and it has been cycling through the images without crashing.
Just thought you might be interested in the fix.
Cheers,
-Dane