On-Demand loading and some of its side-effects#311
Open
nknapp wants to merge 9 commits intoGalleriaJS:masterfrom
Open
On-Demand loading and some of its side-effects#311nknapp wants to merge 9 commits intoGalleriaJS:masterfrom
nknapp wants to merge 9 commits intoGalleriaJS:masterfrom
Conversation
added 9 commits
November 21, 2013 17:46
…ot not occupy space in the thumbnails-list. Otherwise with "thumbnails: lazy" and thumbs loaded at the beginning and the end of the container, the length of the "thumbnails"-container will be too short and the last thumbnails get pushed to the next line.
The option `thumbnails: 'ondemand'` can be set in order to load thumbnails when needed: * Thumbnails that are in the visible range of the thumbnails-view are loaded * Thumbnails, that are adjacent to the visible range (one carousel-width before or after) are loaded. * As the carousel moves, more thumbnails are loaded.
Conflicts: README.rst
…rection, even though too few images are displayed.
…e in the desired direction, even if to few images fit into it."
…y thumbnails This is a fix for commit "5ed3ca89748aa6302cd294f207696e2abb521266". This commit made sure that lazy loaded images are displayed "position:absolute" until they are loaded, in order to make sure they do not occupy space in the thumbscontainer. The side-effect was (in IE 10) that images where displayed for a short time in the left corner of the container after loading, until the position was set to "relative" in "_carousel.update()". This commit also uses the width of not-yet-loaded image containers for computing the total with of the thumbs-container and makes sure that these images get maximal height so that following images really have the expected position.
…" was configured. Bugfix: In some rare cases, updateCarousel() is called before any thumbs are loaded. In such a case, the load method lwas loading the previous images and images ahead, but the the current (i.e. the first) image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
we have implemented an on-demand loading scheme for thumbnails, which loads thumbnails visible in the thumbnails-list and one page ahead and back (in case the user intiially clicks on the to-the-left-button). Details are written in the README.
There was one issue with the lazy thumbnails occupying space before being ready (5ed3ca8) that had to be resolved for this to work properly.
I have only tested the 'ondemand'-feature with the classic theme, it should probably be marked as experimental in the documentation. However, for large image collections, it should reduce downloads from the server.