Config height value used prior to CSS value#307
Open
slykar wants to merge 1 commit intoGalleriaJS:masterfrom
Open
Config height value used prior to CSS value#307slykar wants to merge 1 commit intoGalleriaJS:masterfrom
slykar wants to merge 1 commit intoGalleriaJS:masterfrom
Conversation
The height set in config should be used instead of waiting for the CSS. Sometimes the gallery may be hidden, then the height retrieved is 0, causing a fatal error. To solve this issue, config value should be used if present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The height set in config should be used instead of waiting for the CSS.
Sometimes the gallery may be hidden, then the height retrieved is 0, causing a fatal error.
To solve this issue, config value should be used if present.