Multiple themes#244
Open
jesstelford wants to merge 14 commits intoGalleriaJS:masterfrom
Open
Conversation
This will allow us to switch themes on a per instance basis.
Stop previous timers for delayed loading being overwritten when loadTheme() called quickly in succession in user code.
This is to stop multiple themes from having conflicting styles on the same page without the need for an iframe
Contributor
Author
|
This addresses this Get Satisfaction question, and issue #105. |
https://bugs.webkit.org/show_bug.cgi?id=73152 solution derived from https://gist.github.com/1420621 When 'namespacing' the CSS and isnerting it in Webkit, any styles with a quote had their quotes stripped by WebKit when read, resulting in invalid CSS inserted back into the CSSOM. This commit works around this bug.
|
This should be fixed asap. Couldn't believe when I noticed it can't run multiple themes on same page. Ideally one should be able to include all themes using normal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch implements the ability to use multiple themes (one theme per gallery) when there are multiple galleries.
This should be a backward compatible update - all existing galleries (even those with multiple galleries per page) should still work correctly.
The basic premise of this functionality is to 'namespace' each theme's CSS file with an id by injecting the id into all rules in the file, and adding that id to the .galleria-container element.
Each theme has a unique id based on its name, allowing them to be specified as part of the options list (see documentation for 'theme' option).