feat: week4 task#6
Open
taehyeon1998 wants to merge 1 commit intogonfrom
Open
Conversation
Contributor
|
전체적인 파일 명을 API 구현하며 실제 사용할 것들로 결정하여 잘 만들어둔 것 같아! 정말 사소하게 피드백주고 싶은 내용은 두가지인데,
.gitkeep 파일을 대신 사용하면, 지금처럼 패키지들은 잘 커밋 되면서 리뷰어에게도 의문점 없이 진행이 가능해서 나중에 검토해보면 좋을듯 ~~
이런식으로 정리해보면 좋을 것 같아 |
|
곤 전체적으로 다 잘 설계해줬다! 미션 도메인 안에 가게랑 지역 엔티티까지 다 넣어줬네?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📂 관련 이슈
🛠️ 작업 사항
📸 관련 이미지 (스크린샷 또는 동영상)
💬 기타 설명