chore(retentions): add new retentions method for support drafts#50
Open
raul-facturapi wants to merge 2 commits into
Open
chore(retentions): add new retentions method for support drafts#50raul-facturapi wants to merge 2 commits into
raul-facturapi wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces support for working with draft retentions in the PHP SDK, adding dedicated draft lifecycle methods and adjusting cancellation behavior to support deleting draft retentions. It also adds PHPUnit coverage to validate the generated HTTP requests for these new/updated behaviors.
Changes:
- Add
Retentions::updateDraft(),Retentions::copyToDraft(), andRetentions::stampDraft(), plus deprecated snake_case aliases for backward compatibility. - Allow
Retentions::cancel()to be called without query parameters (enables deleting draft retentions via a plainDELETE). - Add PHPUnit tests verifying request methods, URLs, and payloads for draft retention flows.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| VERSION.md | Documents the new 4.6.0 SDK changes related to draft retentions. |
| tests/Resources/RetentionsTest.php | Adds request-level tests for draft retention creation, update, copy, stamp, cancellation, and filtering. |
| src/Resources/Retentions.php | Implements draft retention methods and makes cancel() query optional; adds deprecated snake_case aliases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javorosas
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.