Compatibility fixed for zlib and minizip#374
Open
arnauddgbes wants to merge 1 commit intoF2I-Consulting:masterfrom
Open
Compatibility fixed for zlib and minizip#374arnauddgbes wants to merge 1 commit intoF2I-Consulting:masterfrom
arnauddgbes wants to merge 1 commit intoF2I-Consulting:masterfrom
Conversation
Summary: The library names for zlib and minizip have been modified in zlib 1.3.1.2 and the current 1.3.2 tags. Hence adding "minizipsd" as possible static/debug name for minizip, and "minizips" as possible static/release name for minizip. For ZLIB, this has been handled by the following patch in CMake 4.2.0: Kitware/CMake@b2c059e Including a copy of this module provides compatibility for configuring the project with older versions of cmake Test Plan: Made a static build of zlib on Windows. Compiling fesapi against it using cmake 3.30 and MSVC 2022. CMake project configuration OK (by setting ZLIB_ROOT and MINIZIP_ROOT), build ok, although several warnings are shown about missing PDB files for libminizip. These warnings are not new.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The library names for zlib and minizip have been modified in zlib 1.3.1.2 and the current 1.3.2 tags.
Hence adding "minizipsd" as possible static/debug name for minizip, and "minizips" as possible static/release name for minizip.
For ZLIB, this has been handled by the following patch in CMake 4.2.0:
Kitware/CMake@b2c059e
Including a copy of this module provides compatibility for configuring the project with older versions of cmake
Does this close any currently open issues?
Yes: #373
Any relevant logs, error output, etc?
Not required, obvious
Any other comments?
Several warnings are shown about missing PDB files for libminizip. These warnings are not new.
Where has this been tested?
Operating System: Windows 11
Platform: Microsoft Visual Studio 2022, CMake 3.30
Made a static build of zlib on Windows.
Compiling fesapi against it using cmake 3.30 and MSVC 2022. CMake project configuration OK (by setting ZLIB_ROOT and MINIZIP_ROOT)