Skip to content

Refactor process execution plumbing#567

Merged
chubes4 merged 2 commits into
mainfrom
refactor/dmc-plumbing-cleanup
Jun 6, 2026
Merged

Refactor process execution plumbing#567
chubes4 merged 2 commits into
mainfrom
refactor/dmc-plumbing-cleanup

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented Jun 6, 2026

Summary

  • Add a shared ProcessRunner for command execution, output capture, timeout handling, environment injection, and progress callbacks.
  • Route git command execution, clone streaming, and worktree bootstrap commands through the shared runner.
  • Reuse shared path traversal detection in workspace writes and cover backslash traversal rejection.

Verification

  • php -l inc/Support/ProcessRunner.php && php -l inc/Support/GitRunner.php && php -l inc/Workspace/WorkspaceWriter.php && php -l inc/Workspace/WorktreeBootstrapper.php && php -l inc/Workspace/WorkspaceRepositoryLifecycle.php && php -l tests/smoke-workspace-edit-context.php
  • php tests/smoke-workspace-edit-context.php && php tests/smoke-worktree-bootstrap.php && php tests/smoke-workspace-clone-ux.php && php tests/smoke-workspace-git-capabilities.php && php tests/smoke-workspace-apply-patch.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Architectural inspection, refactor implementation, and targeted smoke verification. Chris remains responsible for review and merge decisions.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented Jun 6, 2026

Homeboy Results — data-machine-code

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since a0b1795

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27069165230

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine-code --from lint --write
ℹ️ Collect coverage: homeboy test data-machine-code --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine-code --changed-since a0b1795

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27069165230

Audit

audit — passed

Deep dive: homeboy audit data-machine-code --changed-since a0b1795

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/27069165230
Tooling versions
  • Homeboy CLI: homeboy 0.221.0+757cf34
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: e34defd5
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 831e15e into main Jun 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant