Feat/merge with dev#367
Open
dhaval-supraoracles wants to merge 21 commits into
Open
Conversation
… cycle suspension (#313) - If pending system task is cancelled, the task index is removed from the cached list of system tasks - When cycle suspened then system tasks are also included in the removed tasks list of the reported error. Co-authored-by: Aregnaz Harutyunyan <>
Co-authored-by: Saurabh Joshi <sjoshi@supra.com>
* correction on cli command usage (2532) * Correction on the example of --type-args
* add update_unlocking_schedule_unchecked * add scenario that non admin can not invoke schedule update * add vesting delay method for admin (#325) Co-authored-by: Saurabh Joshi <sjoshi@supra.com> --------- Co-authored-by: Saurabh Joshi <sjoshi@supra.com>
Co-authored-by: Saurabh Joshi <sjoshi@supra.com>
…roperly when tasks are stopped (#329) * [AN-Issue-2637] Unlocked valid cycle fee and updated registry state properly when tasks are stopped * Fixed comment --------- Co-authored-by: Aregnaz Harutyunyan <>
Co-authored-by: Supra-RaghulRajeshR <r.rajesh@supraoracle.com>
* WIP: adding leader ban registry module in supra framework * WIP: Resolve comments and added further implementation * resolved comments * Fixed compilation issue * resolved comments * Minor formatiing * added config tests * resolved comments * resolved comments * added few more cases * resolved comments + formatted with movefmt * updated with probation period * added docs from comments and removed reinstate proposer * updated the flow for expiration of bans
* update validator pub keys to support dkg * adds blockmetadata flag * featureflag for blockmetadataext * add consenses_key support for past version * add clan, family committee structure * update dkg module to handle new dkg * change dkg.move to use DkgNodeConfig * on going changes * moved dkg transaction validation to aptosvm * adds dkg transaction to post bls pk shares * removed author from dkgmeta * supra dkg feature flag * update validator pub keys to support dkg * adds blockmetadata flag * featureflag for blockmetadataext * add consenses_key support for past version * add clan, family committee structure * update dkg module to handle new dkg * change dkg.move to use DkgNodeConfig * on going changes * moved dkg transaction validation to aptosvm * adds dkg transaction to post bls pk shares * removed author from dkgmeta * supra dkg feature flag * rebase with dev * add dkg validator transaction validation * adds family check in dkg transaction validation * minor * adds feature gating for validator transaction execution * update dkg transaction execution validation * temporarily support old consensus key * added identity to dkg node config * added dkg events * add consensus key rust type * add dkg event try from for Contract event * changes to get dkg move state * added DKGResharing struct * emit dkg update events * impl from dkg events to contract event * to_bytes for consensuskey * update crypto version * update crypto * update crypto * update crypto * update crypto * update crypto * validator key change and refactor * Revert "validator key change and refactor" This reverts commit 3d14a98. * updated validator public keys and refactoring * ongoing changes * add gas params for supra_stdlib * fmt * ongoing changes to address comments * ongoing changes * minor fixes * adds new method for ValidatorPublicKeys * new methods for DkgNodeConfig and DkgCommittee * update dkg committee to use validator address as identity * add copyright statements * Update validator_public_keys.move (#305) * Update validator_public_keys.move * Add functions for new CertificateThresholdType constant tags (BCFT and Clan Majority) * addressing comments * rename * fix docs * minor fix * resharing config changed to per receiver committee * add epoch, chain_id in onchainaggcommitments * update validator committee keys after dkg * fix test public key * changes to support arbitrary threshold types * dkg for validity & quorum keys * [aptos-labs#2300] Feature flag. * Sc/task/issue 2242 patch2 (#306) * add supra bcft cert feature flag * update md file * addressing comments * made compatible with the new key format * added a fallback to the old format * parsing ed key by `try_from` instead of bcs * Update dkg.md * fixes * conditional consensus key based on bls flag * update validator_config to use ValidatorPublicKeys * update ValidatorPublicKeys to include bcft keys * update gas ver * add supra_stdlib gas params to_on_chain_gas_schedule * add randomness tag to block_prologue_ext * temporarily mark randomness biasable * add SUPRA_DKG to default features * dkg module fixes * fix dkg transactions error handling in vm * added dkg config * dkg handles all bls key types * remove dkg meta set condition for pk shares * adds dkg threshold type for receiver committees * removed error status DKG_META_NOT_SET * distinguish error code for future/past epochs * fixed leader ban test cases * dkg for bcft and clan majority * update crypto version * adds next_epoch_validator_consensus_infos_for_dkg * feat: changes related to the transaction inclusion proof feature (#341) * feat(types,accumulator): Add features for transactions inclusions and events emissions proofs. - RLP's `Encodable` trait implementation for Contract Events. - `get_proof_by_position` method for Merkle Accumulator. * feat: add `EventV2` api type * chore: cargo feature optimization * refactor(aptos-api-types): transformed `Event` to `EventV1` and applied Full-Clone on `EventV2` * feat: add `hash` in `EventV1` with serialization disabled * docs: fix oai docs for `EventV1` * feat(aptos_api_types): add `try_into_v2_events` to convert `ContractEvent` to `EventV2` * feat: add `SUPRA_TRANSACTIONS_INCLUSION_PROOFS` feature flag * feat: replace rlp encoding with custom encoding to generate event hash * chore: replace `alloy` with `sha3` for `Keccak256` impl * fix: Keccack256 hash implementation using `sha3` --------- Co-authored-by: Nikita Puzankov <n.puzankov@supraoracles.com> Co-authored-by: Simon Chen <s.chen@supraoracles.com> * fix: ensure `hash_bytes` gets updated with finalized hash * Updated crypto ref to revision containing ref to bicycl-rs with fully-qualified SSH submodule refs. * update crypto * Updated minimum GAS_UNIT_PRICE from 100 to 100_000 in accordance with the outcome of https://vote.supra.com/proposal/3. (#344) * test fixes * make order of dkg committee consistent with new epoch committee * Fixed DKG config to account for BCFT flag and added missing threshold. Added comments. Regenerated docs. * Fixed DKG config and removed unnecessary test. * Discovered that DKG config is initialised during genesis before feature flags are set, so updated implementation accordingly and added notes. Also fixed supra_governance::reconfigure. * Formatting. * Started work towards adding leader ban registry config to genesis. (#346) * Started work towards adding leader ban registry config to genesis. * added remaining changes for the leader ban config at genesis * added deserilization step * added deserilization step * added deserilization step * fixed leader ban registry package for ban parameters * decoded correct version of params --------- Co-authored-by: Dhaval Purohit <d.purohit@supraoracles.com> * Formatting. * Added TypeTags for UpdateNetworkAndFullnodeAddressesEvent and RotateConsensusKeyEvent. * Added fixes for leader ban registry view (#350) * added fixes for leader ban registry view * fixed the test according to updated changes * PR comments addressed * addressing comments * reverse pending active order for next_validator_consensus_infos --------- Co-authored-by: simonchen-supra <s.chen@supraoracles.com> Co-authored-by: Isaac Doidge <i.doidge@supraoracles.com> Co-authored-by: Mateusz Zając <m.zajac@supraoracles.com> Co-authored-by: Dhaval Purohit <d.purohit@supraoracles.com> Co-authored-by: Panchal Vedant <v.panchal@supraoracles.com> Co-authored-by: Nikita Puzankov <n.puzankov@supraoracles.com> Co-authored-by: Isaac Doidge <30425649+isaacdoidge@users.noreply.github.com>
* Updated validator public key validation logic to enable registration of new format keys before the related feature flag is active whilst maintaining backwards compatibility with the old format when the flag is off. * Restored original DKG framework module and move new Supra DKG into new module to restore compatibility with production framework. * Fixed DKG module names in Rust code. Missed in last commit. * Made DKG init function public for use in governance scripts.
…r consensus keys. (#361)
dhaval-supraoracles
requested review from
aregng,
isaacdoidge,
sjoshisupra and
supra-yoga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.