fix(companion): build native 64-bit NSIS installer#7245
Open
raphaelcoeffic wants to merge 1 commit intomainfrom
Open
fix(companion): build native 64-bit NSIS installer#7245raphaelcoeffic wants to merge 1 commit intomainfrom
raphaelcoeffic wants to merge 1 commit intomainfrom
Conversation
raphaelcoeffic
added
companion
Use $PROGRAMFILES64 instead of $PROGRAMFILES so the 32-bit NSIS installer resolves to "Program Files" rather than "Program Files (x86)" on 64-bit Windows.
raphaelcoeffic
force-pushed
the
cpn-install-path
branch
from
f2d70e3 to
718a8b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NSIS installer was a 32-bit PE, causing $PROGRAMFILES to resolve to "Program Files (x86)" on 64-bit Windows. Adding "Target amd64-unicode" produces a native 64-bit installer where $PROGRAMFILES correctly points to "Program Files".
Fixes #7243