Skip to content

Commit 4980a30

Browse files
kelleymhtyhicks
authored andcommitted
clocksource/drivers/hyper-v: Handle sched_clock differences inline
While the Hyper-V Reference TSC code is architecture neutral, the pv_ops.time.sched_clock() function is implemented for x86/x64, but not for ARM64. Current code calls a utility function under arch/x86 (and coming, under arch/arm64) to handle the difference. Change this approach to handle the difference inline based on whether GENERIC_SCHED_CLOCK is present. The new approach removes code under arch/* since the difference is tied more to the specifics of the Linux implementation than to the architecture. No functional change. Signed-off-by: Michael Kelley <mikelley@microsoft.com> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/1614721102-2241-9-git-send-email-mikelley@microsoft.com Signed-off-by: Wei Liu <wei.liu@kernel.org> (cherry picked from commit eb3e1d3) Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
1 parent aecbbfc commit 4980a30

2 files changed

Lines changed: 24 additions & 11 deletions

File tree

arch/x86/include/asm/mshyperv.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,6 @@ static inline u64 hv_get_register(unsigned int reg)
2929

3030
#define hv_get_raw_timer() rdtsc_ordered()
3131

32-
/*
33-
* Reference to pv_ops must be inline so objtool
34-
* detection of noinstr violations can work correctly.
35-
*/
36-
static __always_inline void hv_setup_sched_clock(void *sched_clock)
37-
{
38-
#ifdef CONFIG_PARAVIRT
39-
pv_ops.time.sched_clock = sched_clock;
40-
#endif
41-
}
42-
4332
void hyperv_vector_handler(struct pt_regs *regs);
4433

4534
static inline void hv_enable_stimer0_percpu_irq(int irq) {}

drivers/clocksource/hyperv_timer.c

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -423,6 +423,30 @@ static struct clocksource hyperv_cs_msr = {
423423
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
424424
};
425425

426+
/*
427+
* Reference to pv_ops must be inline so objtool
428+
* detection of noinstr violations can work correctly.
429+
*/
430+
#ifdef CONFIG_GENERIC_SCHED_CLOCK
431+
static __always_inline void hv_setup_sched_clock(void *sched_clock)
432+
{
433+
/*
434+
* We're on an architecture with generic sched clock (not x86/x64).
435+
* The Hyper-V sched clock read function returns nanoseconds, not
436+
* the normal 100ns units of the Hyper-V synthetic clock.
437+
*/
438+
sched_clock_register(sched_clock, 64, NSEC_PER_SEC);
439+
}
440+
#elif defined CONFIG_PARAVIRT
441+
static __always_inline void hv_setup_sched_clock(void *sched_clock)
442+
{
443+
/* We're on x86/x64 *and* using PV ops */
444+
pv_ops.time.sched_clock = sched_clock;
445+
}
446+
#else /* !CONFIG_GENERIC_SCHED_CLOCK && !CONFIG_PARAVIRT */
447+
static __always_inline void hv_setup_sched_clock(void *sched_clock) {}
448+
#endif /* CONFIG_GENERIC_SCHED_CLOCK */
449+
426450
static bool __init hv_init_tsc_clocksource(void)
427451
{
428452
u64 tsc_msr;

0 commit comments

Comments
 (0)