Skip to content

Commit aecbbfc

Browse files
kelleymhtyhicks
authored andcommitted
clocksource/drivers/hyper-v: Handle vDSO differences inline
While the driver for the Hyper-V Reference TSC and STIMERs is architecture neutral, vDSO is implemented for x86/x64, but not for ARM64. Current code calls into utility functions under arch/x86 (and coming, under arch/arm64) to handle the difference. Change this approach to handle the difference inline based on whether VDSO_CLOCK_MODE_HVCLOCK is present. The new approach removes code under arch/* since the difference is tied more to the specifics of the Linux implementation than to the architecture. No functional change. Signed-off-by: Michael Kelley <mikelley@microsoft.com> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/1614721102-2241-8-git-send-email-mikelley@microsoft.com Signed-off-by: Wei Liu <wei.liu@kernel.org> (cherry picked from commit e4ab465) Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
1 parent 7c54a55 commit aecbbfc

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

arch/x86/include/asm/mshyperv.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ static inline u64 hv_get_register(unsigned int reg)
2727
return value;
2828
}
2929

30-
#define hv_set_clocksource_vdso(val) \
31-
((val).vdso_clock_mode = VDSO_CLOCKMODE_HVCLOCK)
32-
#define hv_enable_vdso_clocksource() \
33-
vclocks_set_used(VDSO_CLOCKMODE_HVCLOCK);
3430
#define hv_get_raw_timer() rdtsc_ordered()
3531

3632
/*

drivers/clocksource/hyperv_timer.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,11 +370,13 @@ static void resume_hv_clock_tsc(struct clocksource *arg)
370370
hv_set_register(HV_REGISTER_REFERENCE_TSC, tsc_msr);
371371
}
372372

373+
#ifdef VDSO_CLOCKMODE_HVCLOCK
373374
static int hv_cs_enable(struct clocksource *cs)
374375
{
375-
hv_enable_vdso_clocksource();
376+
vclocks_set_used(VDSO_CLOCKMODE_HVCLOCK);
376377
return 0;
377378
}
379+
#endif
378380

379381
static struct clocksource hyperv_cs_tsc = {
380382
.name = "hyperv_clocksource_tsc_page",
@@ -384,7 +386,12 @@ static struct clocksource hyperv_cs_tsc = {
384386
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
385387
.suspend= suspend_hv_clock_tsc,
386388
.resume = resume_hv_clock_tsc,
389+
#ifdef VDSO_CLOCKMODE_HVCLOCK
387390
.enable = hv_cs_enable,
391+
.vdso_clock_mode = VDSO_CLOCKMODE_HVCLOCK,
392+
#else
393+
.vdso_clock_mode = VDSO_CLOCKMODE_NONE,
394+
#endif
388395
};
389396

390397
static u64 notrace read_hv_clock_msr(void)
@@ -439,7 +446,6 @@ static bool __init hv_init_tsc_clocksource(void)
439446
tsc_msr = tsc_msr | 0x1 | (u64)phys_addr;
440447
hv_set_register(HV_REGISTER_REFERENCE_TSC, tsc_msr);
441448

442-
hv_set_clocksource_vdso(hyperv_cs_tsc);
443449
clocksource_register_hz(&hyperv_cs_tsc, NSEC_PER_SEC/100);
444450

445451
hv_sched_clock_offset = hv_read_reference_counter();

0 commit comments

Comments
 (0)