Skip to content

Switching Margo's Go To Definition to use the types package#571

Open
dlclark wants to merge 11 commits into
DisposaBoy:masterfrom
dlclark:master
Open

Switching Margo's Go To Definition to use the types package#571
dlclark wants to merge 11 commits into
DisposaBoy:masterfrom
dlclark:master

Conversation

@dlclark

@dlclark dlclark commented Dec 1, 2014

Copy link
Copy Markdown

This change allows Go To Definition to search across a wider variety of use cases. It also adds Find Usages (based on the same code). Most of the file changes are for vendoring the new dependencies.

@DisposaBlackSwan

Copy link
Copy Markdown

Thanks, I'll try and have a look this weekend

@ghost

ghost commented Dec 19, 2014

Copy link
Copy Markdown

need this so much

@ghost

ghost commented Jan 5, 2015

Copy link
Copy Markdown

hey, boss, when we could update :)

@DisposaBlackSwan

Copy link
Copy Markdown

I need to sort some stuff out first before I decide whether to merge or not. You don't need to wait for that, just git pull from the fork and use it.

@ypapax

ypapax commented Apr 7, 2015

Copy link
Copy Markdown

@DisposaBlackSwan how to "git pull from the fork" to use these features now? What exact git command should I run?

@stevekuznetsov

Copy link
Copy Markdown

Is this PR going in sometime? This is a huge feature gap.

@xinhuang327

Copy link
Copy Markdown

Great improvement, just download dlclark's fork and replace the original GoSublime package. Don't forget to remove the compiled original margo binary in User directory too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants