Fix: deletion of ProjectProperties#57
Merged
nscuro merged 2 commits intoDependencyTrack:mainfrom Apr 14, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Bastiaan Nijkamp <b-github@wesnijk.nl>
f8d1d54 to
69d1311
Compare
nscuro
requested changes
Apr 14, 2026
Signed-off-by: Bastiaan Nijkamp <b-github@wesnijk.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletion of project properties currently fails with the following error message:
This happens because the
ProjectPropertystruct includes all fields when marshalling to json, including empty fields. The DT api does not allow an emptypropertyType.I thought about adding
omitemptyto all fields exceptgroupNameandpropertyNamebut that might break semantics of the other calls. Instead, i created a newProjectPropertyDeletestruct that only includes the two fields needed for the delete endpoint.I also used AI (Claude Opus 4.6) to generate tests for projectProperties, which i reviewed and modified carefully and take full responsibility for. I also noted that the
GetAllmethod acceptsPageOptionsbut that the API is not paginated at all. As a result totalCount is always returned as 0. This PR does not fix that.