docs: revise alpha stat taxonomy#277
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0549f4ab5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| | `critical_chance` | equipment, skill, dexterity or perception | Critical hit budget. | | ||
| | `critical_damage` | weapon, skill, equipment | Critical damage budget. | |
There was a problem hiding this comment.
Align the crit stat field names
These newly introduced identifiers do not match the canonical secondary-stat contract elsewhere in the same stat migration: docs/design/14-character-stat-and-relationship-system.md defines crit_chance and crit_damage, and docs/design/10-character-profile-agent-memory.md repeats those runtime keys. If an implementer follows this alpha stats table, payloads/UI can be built around critical_* while the runtime contract expects crit_*, creating an avoidable schema mismatch during the migration.
Useful? React with 👍 / 👎.
| max_energy = 20 + focus * 4 + level * 3 | ||
| attack_power = weapon_base + primary_stat * 0.6 + level * 1.5 | ||
| defense_power = armor_base + endurance * 0.5 | ||
| max_health = 60 + vitality * 5 + level * 5 |
There was a problem hiding this comment.
Align the max_health formula with the progression default
This section says the level/XP packet in 57-alpha-level-core-stat-progression.md fixes the first implementation defaults, but this formula omits frame_grade_bonus and uses level * 5 while that referenced default now uses level * 6 + frame_grade_bonus. That leaves two conflicting alpha HP formulas for server/client implementation, so one of these docs should be made the single default.
Useful? React with 👍 / 👎.
| | `max_time_capacity` | integer | Derived or cached | | ||
| | `attack_power` | integer | Derived or cached | | ||
| | `defense_power` | integer | Derived or cached | | ||
| | `armor_rating` | integer | Derived or cached | |
There was a problem hiding this comment.
Preserve defense_power during the stat migration
The target contract replaces defense_power with armor_rating without listing defense_power as a legacy compatibility field, but the current Nakama seed payloads and Unity DTO/debug UI still emit or read defense_power (for example backend/nakama/modules/index.ts and Unity/Assets/_SecondSpawn/Scripts/AI/AgentContextDto.cs). During the coordinated migration described here, implementers could drop the old key at compatibility boundaries and break existing HUD/context consumers; keep defense_power documented as a read-only legacy alias until those payloads are actually migrated.
Useful? React with 👍 / 👎.
Summary
Verification
tools\windows\check-backlog-sync.ps1- OKgit diff --check- OKLocal Review