Skip to content

Improvement: Cad geometry component test#2150

Open
sandro-elsweijer wants to merge 14 commits into
mainfrom
curved_geom_test
Open

Improvement: Cad geometry component test#2150
sandro-elsweijer wants to merge 14 commits into
mainfrom
curved_geom_test

Conversation

@sandro-elsweijer
Copy link
Copy Markdown
Member

Describe your changes here:
This PR adds a cad geometry component test. It refines a curved base forest and checks if it matches a target forest. This tests the msh reader as well as the cad geometries.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer added priority:medium Should be solved within half a year workload:low Would take half a day or less labels Feb 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.70%. Comparing base (92212f7) to head (b56a956).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2150   +/-   ##
=======================================
  Coverage   78.69%   78.70%           
=======================================
  Files         115      115           
  Lines       19206    19211    +5     
=======================================
+ Hits        15115    15120    +5     
  Misses       4091     4091           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/t8_cad/t8_cad_handle.cxx
Comment thread src/t8_forest/t8_forest.cxx Outdated
Comment thread src/t8_forest/t8_forest_geometrical.h Outdated
Comment thread src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx Outdated
Comment thread src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.hxx Outdated
Comment thread src/t8_types/t8_vec.h Outdated
Comment thread src/t8_types/t8_vec.cxx Outdated
sandro-elsweijer and others added 2 commits May 13, 2026 10:52
Copy link
Copy Markdown
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing testsuite - then we should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Should be solved within half a year workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants