chore: remove Checkout.com integration#3703
Open
TaprootFreak wants to merge 1 commit into
Open
Conversation
Closes #3699. - Delete src/integration/checkout/ (SDK wrapper, module, dto, service) and the CheckoutObserver. - Delete the CheckoutTx entity, service, repository, mock and the FiatPayIn module (its only purpose was Checkout sync). - Drop the four live consumers of CheckoutService: createPaymentLink in BuyService, refundPayment in BuyCryptoService, getBalances in BankAdapter, and the FiatPayInSyncService itself. - Remove the checkoutTx relation from BuyCrypto, Transaction and Recall, plus all entity.checkoutTx branches in AML, support, gs, history mappers and transaction services. - Drop the last7dCheckoutVolume parameter chain through amlCheckAndFillUp / getAmlResult / getAmlErrors / amlRuleCheck. - Remove dead AmlRule quote-check branches that fired only on paymentMethodIn === CARD; paymentMethodIn is no longer needed in amlRuleQuoteCheck. - Strip the checkout config block, CKO_* env vars, the bicep params (ckoPublicKey/ckoSecretKey/ckoEntityId) and the checkout-sdk-node dependency. - Clean up corresponding test specs and the unused paymentLink field on BuyPaymentInfoDto / CustodyOrderBuyResponseDto. Preserved on purpose: existing *Checkout* migrations, AmlRule enum values (DB-referenced), TransactionTypeInternal.CHECKOUT_LTD, Blockchain.CHECKOUT, CardBankName.CHECKOUT and the dormant checkout_tx table — historical rows must stay readable. A follow-up cleanup migration can be filed separately.
5 tasks
davidleomay
reviewed
May 13, 2026
| * !entity.user.wallet.amlRuleList.includes(AmlRule.RULE_14) && | ||
| * !refUser?.userData?.isTrustedReferrer && // <-- This is the new condition | ||
| * (entity.bankTx || entity.checkoutTx) && | ||
| * (entity.bankTx || entity.bankTx only) && |
Member
There was a problem hiding this comment.
looks like a search-and-replace artifact
| }); | ||
|
|
||
| describe('when transaction is swap (no bankTx or checkoutTx)', () => { | ||
| describe('when transaction is swap (no bankTx or bankTx only)', () => { |
Member
There was a problem hiding this comment.
Mark the unused AML Rules as deprecated in src/subdomains/core/aml/enums/aml-rule.enum.ts?
Comment on lines
-77
to
-79
| @OneToOne(() => CheckoutTx, { nullable: true }) | ||
| @JoinColumn() | ||
| checkoutTx?: CheckoutTx; |
Member
There was a problem hiding this comment.
Keep the reference for history
Comment on lines
-14
to
-15
| @ManyToOne(() => CheckoutTx) | ||
| checkoutTx: CheckoutTx; |
Member
There was a problem hiding this comment.
Keep the reference for history
Comment on lines
-9
to
+8
| @Index((r: Recall) => [r.bankTx, r.checkoutTx, r.sequence], { unique: true }) | ||
| @Index((r: Recall) => [r.bankTx, r.sequence], { unique: true }) |
Comment on lines
-125
to
-126
| @OneToOne(() => CheckoutTx, (checkoutTx) => checkoutTx.transaction, { nullable: true }) | ||
| checkoutTx?: CheckoutTx; |
Member
There was a problem hiding this comment.
Keep the reference for history
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3699. Removes the Checkout.com payment integration entirely:
src/integration/checkout/(SDK wrapper, module, dto, service) and theCheckoutObserver.CheckoutTxentity, service, repository, mock and theFiatPayInmodule (its only purpose was Checkout sync).CheckoutService:createPaymentLinkinBuyService,refundPaymentinBuyCryptoService,getBalancesinBankAdapter, and theFiatPayInSyncServiceitself.checkoutTxrelation fromBuyCrypto,TransactionandRecall, plus allentity.checkoutTxbranches in AML, support, gs, history mappers and transaction services.last7dCheckoutVolumeparameter chain throughamlCheckAndFillUp/getAmlResult/getAmlErrors/amlRuleCheck.AmlRulequote-check branches that fired only onpaymentMethodIn === CARD;paymentMethodInis no longer needed inamlRuleQuoteCheck.checkoutconfig block,CKO_*env vars, the bicep params (ckoPublicKey/ckoSecretKey/ckoEntityId) and thecheckout-sdk-nodedependency.paymentLinkfield onBuyPaymentInfoDto/CustodyOrderBuyResponseDto.Preserved on purpose
*Checkout*migrations stay untouched (historical record).AmlRuleenum values 1/4/6/7/9/10/12/13 stay (DB-referenced); their cases simply have no live branch anymore.TransactionTypeInternal.CHECKOUT_LTD,Blockchain.CHECKOUT,CardBankName.CHECKOUT,TransactionRequest.paymentLinkand the dormantcheckout_txtable remain to keep historical rows readable. A follow-up cleanup migration can be filed separately.63 files changed, +81 / -1414.
Test plan
yarn lintyarn format:checkyarn buildyarn test(931 passed)