Skip to content

fix(textarea): set value correctly#575

Open
ryan-nauman-cs wants to merge 1 commit intoCrowdStrike:mainfrom
ryan-nauman-cs:fix/rn-textarea
Open

fix(textarea): set value correctly#575
ryan-nauman-cs wants to merge 1 commit intoCrowdStrike:mainfrom
ryan-nauman-cs:fix/rn-textarea

Conversation

@ryan-nauman-cs
Copy link
Copy Markdown

Fixes #527. This is the same fix as CrowdStrike/ember-toucan-core#447. I've added a test to verify its now working properly.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: 86a8d76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryan-nauman-cs
Copy link
Copy Markdown
Author

@simonihmig i was unable to get changeset to play nicely.

$ pnpm changeset
🦋  Which packages would you like to include? · ember-headless-form
🦋  Which packages should have a major bump? · No items were selected
🦋  Which packages should have a minor bump? · No items were selected
🦋  The following packages will be patch bumped:
🦋  ember-headless-form@1.1.1
🦋  Please enter a summary for this change (this will be in the changelogs).
🦋    (submit empty line to open external editor)
🦋  Summary · Fix textarea value tracking 
🦋  
🦋  === Summary of changesets ===
🦋  patch:  ember-headless-form
🦋  
🦋  Note: All dependents of these packages that will be incompatible with the new version will be patch bumped when this changeset is applied.
🦋  
🦋  Is this your desired changeset? (Y/n) · true
🦋  error Error [ERR_REQUIRE_ESM]: require() of ES Module ember-headless-form/node_modules/.pnpm/prettier-plugin-ember-template-tag@2.0.5_prettier@2.8.8/node_modules/prettier-plugin-ember-template-tag/dist/prettier-plugin-ember-template-tag.js from ember-headless-form/node_modules/.pnpm/prettier@2.8.8/node_modules/prettier/index.js not supported.
🦋  error Instead change the require of prettier-plugin-ember-template-tag.js in ember-headless-form/node_modules/.pnpm/prettier@2.8.8/node_modules/prettier/index.js to a dynamic import() which is available in all CommonJS modules.
🦋  error     at ember-headless-form/node_modules/.pnpm/prettier@2.8.8/node_modules/prettier/index.js:38143:10
🦋  error     at Array.map (<anonymous>)
🦋  error     at Object.load (ember-headless-form/node_modules/.pnpm/prettier@2.8.8/node_modules/prettier/index.js:38141:128)
🦋  error     at Object.load [as loadPlugins] (ember-headless-form/node_modules/.pnpm/prettier@2.8.8/node_modules/prettier/index.js:16147:23)
🦋  error     at ember-headless-form/node_modules/.pnpm/prettier@2.8.8/node_modules/prettier/index.js:38181:24 {
🦋  error   code: 'ERR_REQUIRE_ESM'
🦋  error }

@simonihmig
Copy link
Copy Markdown
Contributor

LGTM! But the repo is not in a good shape, the failure is not related to your PR. I wanted to look at this, but haven't yet found the time given other priorities... 😩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Textarea might not update value property correctly

3 participants