-
Notifications
You must be signed in to change notification settings - Fork 1
CXH-1390 CXP-481 Support for Incremental Sync #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JavierCarnelli-ConductorOne
wants to merge
8
commits into
main
Choose a base branch
from
feat/CXH-1390
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
566a40c
feat: include support for incremental sync
JavierCarnelli-ConductorOne a79d0e0
feat: add primary_key to resource-level incremental_sync pagination i…
JavierCarnelli-ConductorOne f1c9e74
fix: guard earliestEvent lower-bound to committed cursors only in eve…
JavierCarnelli-ConductorOne cff220b
fix: address review bugs in incremental sync implementation
JavierCarnelli-ConductorOne 2d9eded
fix: address review feedback on incremental sync implementation
JavierCarnelli-ConductorOne 28c9e4e
fix: address PR comments
JavierCarnelli-ConductorOne 695c81a
test: add tests for event feed incremental sync
JavierCarnelli-ConductorOne f5e1226
fix: address PR comments on sql_syncer Get method
JavierCarnelli-ConductorOne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep some comments as notes next to the fields/definitions?