London | 26-ITP-May | Dipa Sarker | Sprint 1 | T-shirt Order Form#1263
London | 26-ITP-May | Dipa Sarker | Sprint 1 | T-shirt Order Form#1263Dipa-Sarker wants to merge 2 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Dipa-Sarker
added
the
Needs Review
|
Hello, I had some difficulties with Git setup and repository configuration while working on this task, so my commits are fewer than expected. I resolved the issues and completed the task. Please let me know if I should improve my commit frequency for future assignments. Hopefully, I will concern about this guideline in future. |
Luro91
added
the
Review in progress
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
The code works well. Please have a look at the formatting
| <div> | ||
| <label for="name">Customer Name</label> | ||
| <input |
There was a problem hiding this comment.
The formatting standard for HTML elements is to use indentation on children elements. How can you ensure consistent formatting in your code?
There was a problem hiding this comment.
Fixed the indentation formatting for the child elements. Thanks for the feedback!
Luro91
added
Reviewed
Dipa-Sarker
added
Needs Review
2 participants
Learners, PR Template
Self checklist
Changelist
• Created semantic HTML form for T-shirt order
• Added validation for customer name and email
• Added dropdown selection for colour (3 options)
• Added dropdown selection for size (6 options)
• Styled form using CSS
• Ensured all fields are required