Skip to content

chore: move callgrind skip obj API to instrument-hooks#123

Open
not-matthias wants to merge 2 commits into
masterfrom
cod-2658-move-object-skip-logic-into-instrument-hooks
Open

chore: move callgrind skip obj API to instrument-hooks#123
not-matthias wants to merge 2 commits into
masterfrom
cod-2658-move-object-skip-logic-into-instrument-hooks

Conversation

@not-matthias
Copy link
Copy Markdown
Member

@not-matthias not-matthias commented May 20, 2026

No description provided.

Drop the locally-defined VG_USERREQ__ADD_OBJ_SKIP trapdoor and the
Python-side realpath resolution. Both now live in instrument-hooks
(65a7afb), so the binding just forwards to the shared helper.

Refs COD-2658.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 20, 2026

Merging this PR will not alter performance

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 17 improved benchmarks
❌ 17 regressed benchmarks
✅ 243 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_multiprocessing_map[10000] 87.1 ms 97.5 ms -10.73%
WallTime test_pipe_communication[10000] 12.6 ms 12.3 ms +2.82%
WallTime test_fs_write[10000] 44.1 µs 42.1 µs +4.77%
WallTime test_recursive_fibo_20 5.2 ms 5.4 ms -2.25%
WallTime test_open_close_fd[100] 883.6 µs 907.6 µs -2.65%
WallTime test_color[graph0-3] 31.5 µs 30.6 µs +2.76%
WallTime test_solve_crossword[puzzle0-words0] 2.2 µs 2.3 µs -4.39%
WallTime test_tcp_connection[1.1.1.1-53] 993.8 µs 1,084.8 µs -8.39%
WallTime test_multiprocessing_map[1000] 62.5 ms 60.4 ms +3.55%
WallTime test_minimax[scores0] 8.4 µs 7.9 µs +6.11%
WallTime test_make_bandpass 5.7 µs 5.4 µs +6.27%
WallTime test_sleep[0.001] 1 ms 1.1 ms -3.2%
WallTime test_array_alloc[100] 1.2 µs 1.2 µs -2.68%
WallTime test_open_close_fd[10] 98.2 µs 92.9 µs +5.75%
WallTime test_noop_pass 543.7 ns 517.6 ns +5.05%
WallTime test_generate_all_subsequences[sequence1] 97.3 µs 94.7 µs +2.82%
WallTime test_make_highshelf 8.3 µs 7.6 µs +8.15%
WallTime test_tcp_connection[8.8.8.8-53] 711.2 µs 915 µs -22.27%
WallTime test_pipe_communication[100] 6.5 ms 6.6 ms -2.22%
WallTime test_hostname_resolution[1.1.1.1] 8.2 µs 7.9 µs +3.13%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cod-2658-move-object-skip-logic-into-instrument-hooks (d1d58f2) with master (fc33d20)

Open in CodSpeed

@not-matthias not-matthias marked this pull request as ready for review May 20, 2026 13:15
Copy link
Copy Markdown
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olgtm

Comment on lines 231 to 234
try:
from . import dist_instrument_hooks # type: ignore
except ImportError:
return
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This funciton should be a class function of InstrumentHooks, and use self._module.callgrind_add_obj_skip

I've pushed a commit to remove a similar import I had added which was absolutely not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants