Fix python version module compatible (TEAM-11049)

[Dawei-Pang]

When running the head of master branch, we observed the followed problem, for example: https://openqa.suse.de/tests/21364964#step/hawk_gui/89

TEST: test_add_virtual_ip: Add virtual IP from the Wizard
Traceback (most recent call last):
  File "/hawk_test.py", line 181, in <module>
    sys.exit(main())
  File "/hawk_test.py", line 128, in main
    browser.test('test_add_virtual_ip', results, args.virtual_ip)
  File "/hawk_test_driver.py", line 337, in test
    if getattr(self, testname)(*extra):
  File "/hawk_test_driver.py", line 1042, in test_add_virtual_ip
    self.click_if_major_version("15", 'configuration')
  File "/hawk_test_driver.py", line 199, in click_if_major_version
    if Version(self.test_version) >= Version(version_to_check):
  File "/usr/lib/python3.6/site-packages/packaging/version.py", line 260, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: '15-SP7'

Filed a JIRA ticket https://jira.suse.com/browse/TEAM-11049

After some research, commit cbcd346 modified
from distutils.version import LooseVersion as Version to from packaging.version import Version
The new "Version" method cannot accept the string like "15-SP7" directly, so I would like to check VERSION_ID in /etc/os-release instead of VERSION for compatible.

VRs:
https://openqa.suse.de/tests/21450880 15-SP4
https://openqa.suse.de/tests/21450874 15-SP5
https://openqa.suse.de/tests/21451116 15-SP6
https://openqa.suse.de/tests/21450865 15-SP7
https://openqa.suse.de/tests/21426733 16.0 (pending)

[mpagot]

LGTM

[badboywj]

LGTM, thanks

[alvarocarvajald]

Elsewhere the test is doing: https://github.com/ClusterLabs/hawk/blob/master/e2e_test/hawk_test_results.py#L35-L37

Which is perhaps harder to read, but avoids running a shell.

Perhaps we can move those 3 lines here, then do:

test_version = osrel['VERSION_ID']

And then pass the PRETTY_NAME as an argument to results = ResultSet() (which is some lines above), like:

results = ResultSet(osrel['PRETTY_NAME'])
results.add_ssh_tests()

In any case, I'm approving. Changes LGTM.

[Dawei-Pang]

Thanks, would you please help to review again?

[alvarocarvajald]

LGTM

[alvarocarvajald]

Why not?

        with open('/etc/os-release', encoding="utf-8") as file:
            lines = file.read().splitlines()

[Dawei-Pang]

From my understanding, the original codes fetch OS version from remote HA nodes, not local system running HAWK, so using ssh.ssh.exec_command('cat /etc/os-release')

[aleksei-burlakov]

I see you are changing VERSION in favor of VERSION_ID, which is indeed more preferable. But this change is also introduced in #310. If merge the PRs chronologically, there might be a conflict.