Skip to content

fix: block tool calls when a dialog is open #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zerone0x wants to merge 3 commits into from
Closed

fix: block tool calls when a dialog is open #1842

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cde4dc1
docs: document autoconnect network request history
zerone0x Apr 10, 2026
7d3f02b
fix: block tool calls when a dialog is open
zerone0x Apr 10, 2026
72bc89d
docs: remove extra note block
zerone0x Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,9 @@ Check the performance of https://developers.chrome.com

> [!NOTE]
> The <code>autoConnect</code> option requires the user to start Chrome. If the user has multiple active profiles, the MCP server will connect to the default profile (as determined by Chrome). The MCP server has access to all open windows for the selected profile.
>
> [!NOTE]
Copy link
Copy Markdown
Collaborator

@Lightning00Blade Lightning00Blade Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert unrelated changes.

Copy link
Copy Markdown
Author

@zerone0x zerone0x Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

> Network requests that occurred before the MCP server connected are not available via <code>list_network_requests</code> / <code>get_network_request</code>. If you need those, start the MCP server first or reload the page after it connects.

The Chrome DevTools MCP server will try to connect to your running Chrome
instance. It shows a dialog asking for user permission.
Expand Down
5 changes: 5 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,11 @@ export async function createMcpServer(
? context.getPageById(params.pageId)
: context.getSelectedMcpPage();
response.setPage(page);
if (page.getDialog() && tool.name !== 'handle_dialog') {
throw new Error(
'A browser dialog is open. Call handle_dialog to accept or dismiss it before continuing.',
);
}
await tool.handler(
{
params,
Expand Down